Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: media/audio/audio_output_proxy.h

Issue 2621993002: Makes AudioOutputProxy -> AudioOutputDispatcher reference weak. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_proxy.h
diff --git a/media/audio/audio_output_proxy.h b/media/audio/audio_output_proxy.h
index 0b358087348f307db5c98da281417a7048e66d1c..16a062824ea55d81aaf86c00dea8907d9307ef3f 100644
--- a/media/audio/audio_output_proxy.h
+++ b/media/audio/audio_output_proxy.h
@@ -7,6 +7,7 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "base/threading/non_thread_safe.h"
#include "media/audio/audio_io.h"
#include "media/base/audio_parameters.h"
@@ -28,7 +29,7 @@ class MEDIA_EXPORT AudioOutputProxy
public NON_EXPORTED_BASE(base::NonThreadSafe) {
public:
// Caller keeps ownership of |dispatcher|.
- explicit AudioOutputProxy(AudioOutputDispatcher* dispatcher);
+ explicit AudioOutputProxy(base::WeakPtr<AudioOutputDispatcher> dispatcher);
// AudioOutputStream interface.
bool Open() override;
@@ -39,7 +40,7 @@ class MEDIA_EXPORT AudioOutputProxy
void Close() override;
AudioOutputDispatcher* get_dispatcher_for_testing() const {
- return dispatcher_;
+ return dispatcher_.get();
}
private:
@@ -54,7 +55,7 @@ class MEDIA_EXPORT AudioOutputProxy
~AudioOutputProxy() override;
- AudioOutputDispatcher* dispatcher_;
+ base::WeakPtr<AudioOutputDispatcher> dispatcher_;
State state_;
// Need to save volume here, so that we can restore it in case the stream

Powered by Google App Engine
This is Rietveld 408576698