Improve HttpStreamFactory NetLog events

net/http/http_stream_factory_impl_job.cc

Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index b8a74c3a388f2724efa916c44b55068617252459..3fce6cf8693ed02207bfd3b142d3c20c0ffb7a8c 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -686,15 +686,13 @@ int HttpStreamFactoryImpl::Job::StartInternal() {
 int HttpStreamFactoryImpl::Job::DoStart() {
   const NetLogWithSource* net_log = delegate_->GetNetLog(this);
 
-  if (net_log) {

[eroman, 2017/01/25 19:55:26]

It isn't clear why this removal is safe when reading this line. From an
interface perspective, GetNetLog() can return nullptr.

It may be that in practice based on how the pieces are connected (does this
delegate come from JobController, which now returns non-null?) this is never
null, but that coupling between implementations is not obvious.

I suggest keeping the null-check, even if in practice the concrete delegate
implementation won't hit it.

[xunjieli, 2017/01/25 21:41:48]

Done.

-    net_log_.BeginEvent(
-        NetLogEventType::HTTP_STREAM_JOB,
-        base::Bind(&NetLogHttpStreamJobCallback, net_log->source(),
-                   &request_info_.url, &origin_url_, &alternative_service_,
-                   priority_));
-    net_log->AddEvent(NetLogEventType::HTTP_STREAM_REQUEST_STARTED_JOB,
-                      net_log_.source().ToEventParametersCallback());
-  }
+  net_log_.BeginEvent(
+      NetLogEventType::HTTP_STREAM_JOB,
+      base::Bind(&NetLogHttpStreamJobCallback, net_log->source(),
+                 &request_info_.url, &origin_url_, &alternative_service_,
+                 priority_));
+  net_log->AddEvent(NetLogEventType::HTTP_STREAM_REQUEST_STARTED_JOB,
+                    net_log_.source().ToEventParametersCallback());
 
   // Don't connect to restricted ports.
   if (!IsPortAllowedForScheme(destination_.port(),