Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: net/http/http_stream_factory_impl_job_controller.h

Issue 2621983004: Improve HttpStreamFactory NetLog events (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job_controller.h
diff --git a/net/http/http_stream_factory_impl_job_controller.h b/net/http/http_stream_factory_impl_job_controller.h
index ab829e8fedd809864c14701e9570e644c0e406d6..73f5975c43e4b91d2c3070113cfbd0272cf4780b 100644
--- a/net/http/http_stream_factory_impl_job_controller.h
+++ b/net/http/http_stream_factory_impl_job_controller.h
@@ -21,7 +21,9 @@ class HttpStreamFactoryImpl::JobController
JobController(HttpStreamFactoryImpl* factory,
HttpStreamRequest::Delegate* delegate,
HttpNetworkSession* session,
- JobFactory* job_factory);
+ JobFactory* job_factory,
+ bool is_preconnect,
+ const NetLogWithSource& net_log);
~JobController() override;
@@ -40,7 +42,6 @@ class HttpStreamFactoryImpl::JobController
HttpStreamRequest::Delegate* delegate,
WebSocketHandshakeStreamBase::CreateHelper*
websocket_handshake_stream_create_helper,
- const NetLogWithSource& net_log,
HttpStreamRequest::StreamType stream_type,
RequestPriority priority,
const SSLConfig& server_ssl_config,
@@ -178,8 +179,7 @@ class HttpStreamFactoryImpl::JobController
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HttpStreamRequest::Delegate* delegate,
- HttpStreamRequest::StreamType stream_type,
- const NetLogWithSource& net_log);
+ HttpStreamRequest::StreamType stream_type);
// Attaches |job| to |request_|. Does not mean that |request_| will use |job|.
void AttachJob(Job* job);
@@ -269,7 +269,7 @@ class HttpStreamFactoryImpl::JobController
HttpStreamRequest::Delegate* const delegate_;
// True if this JobController is used to preconnect streams.
- bool is_preconnect_;
+ const bool is_preconnect_;
// |main_job_| is a job waiting to see if |alternative_job_| can reuse a
// connection. If |alternative_job_| is unable to do so, |this| will notify
@@ -302,6 +302,8 @@ class HttpStreamFactoryImpl::JobController
// True if an alternative proxy server job can be started to fetch |request_|.
bool can_start_alternative_proxy_job_;
+ const NetLogWithSource net_log_;
+
base::WeakPtrFactory<JobController> ptr_factory_;
};

Powered by Google App Engine
This is Rietveld 408576698