Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: net/http/http_stream_factory_impl_request_unittest.cc

Issue 2621983004: Improve HttpStreamFactory NetLog events (Closed)
Patch Set: fix compile Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_request_unittest.cc
diff --git a/net/http/http_stream_factory_impl_request_unittest.cc b/net/http/http_stream_factory_impl_request_unittest.cc
index f8b1c393314d5cc58d3175f3367deff95a1ddc99..6d9b72a4d8915ea7c5607c298642f0bc2e369415 100644
--- a/net/http/http_stream_factory_impl_request_unittest.cc
+++ b/net/http/http_stream_factory_impl_request_unittest.cc
@@ -32,12 +32,13 @@ TEST_F(HttpStreamFactoryImplRequestTest, SetPriority) {
static_cast<HttpStreamFactoryImpl*>(session->http_stream_factory());
MockHttpStreamRequestDelegate request_delegate;
TestJobFactory job_factory;
+ HttpRequestInfo request_info;
HttpStreamFactoryImpl::JobController* job_controller =
- new HttpStreamFactoryImpl::JobController(factory, &request_delegate,
- session.get(), &job_factory);
+ new HttpStreamFactoryImpl::JobController(
+ factory, &request_delegate, session.get(), &job_factory, request_info,
+ /*is_preconnect=*/false);
factory->job_controller_set_.insert(base::WrapUnique(job_controller));
Bence 2017/01/28 02:08:25 I really like your change in http_stream_factory_i
xunjieli 2017/01/30 14:08:39 Done.
- HttpRequestInfo request_info;
std::unique_ptr<HttpStreamFactoryImpl::Request> request(
job_controller->Start(request_info, &request_delegate, nullptr,
NetLogWithSource(), HttpStreamRequest::HTTP_STREAM,

Powered by Google App Engine
This is Rietveld 408576698