Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2148)

Unified Diff: net/http/http_stream_factory_impl_job_controller.h

Issue 2621983004: Improve HttpStreamFactory NetLog events (Closed)
Patch Set: self review 2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job_controller.h
diff --git a/net/http/http_stream_factory_impl_job_controller.h b/net/http/http_stream_factory_impl_job_controller.h
index b7f8ac363e92fcde63865959c0a64fe6c15daeb6..635cf9fc18d343f74705f8ead8399b5b2eaef574 100644
--- a/net/http/http_stream_factory_impl_job_controller.h
+++ b/net/http/http_stream_factory_impl_job_controller.h
@@ -22,7 +22,8 @@ class HttpStreamFactoryImpl::JobController
JobController(HttpStreamFactoryImpl* factory,
HttpStreamRequest::Delegate* delegate,
HttpNetworkSession* session,
- JobFactory* job_factory);
+ JobFactory* job_factory,
+ bool is_preconnect);
~JobController() override;
@@ -34,6 +35,9 @@ class HttpStreamFactoryImpl::JobController
GURL ApplyHostMappingRules(const GURL& url, HostPortPair* endpoint);
+ // Associates |net_log_| with |source_net_log|.
+ void AssociateWithNetLogSource(const NetLogWithSource& source_net_log);
+
// Methods below are called by HttpStreamFactoryImpl only.
// Creates request and hands out to HttpStreamFactoryImpl, this will also
// create Job(s) and start serving the created request.
@@ -41,7 +45,7 @@ class HttpStreamFactoryImpl::JobController
HttpStreamRequest::Delegate* delegate,
WebSocketHandshakeStreamBase::CreateHelper*
websocket_handshake_stream_create_helper,
- const NetLogWithSource& net_log,
+ const NetLogWithSource& source_net_log,
HttpStreamRequest::StreamType stream_type,
RequestPriority priority,
const SSLConfig& server_ssl_config,
@@ -188,8 +192,7 @@ class HttpStreamFactoryImpl::JobController
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HttpStreamRequest::Delegate* delegate,
- HttpStreamRequest::StreamType stream_type,
- const NetLogWithSource& net_log);
+ HttpStreamRequest::StreamType stream_type);
// Attaches |job| to |request_|. Does not mean that |request_| will use |job|.
void AttachJob(Job* job);
@@ -279,7 +282,7 @@ class HttpStreamFactoryImpl::JobController
HttpStreamRequest::Delegate* const delegate_;
// True if this JobController is used to preconnect streams.
- bool is_preconnect_;
+ const bool is_preconnect_;
// |main_job_| is a job waiting to see if |alternative_job_| can reuse a
// connection. If |alternative_job_| is unable to do so, |this| will notify
@@ -315,6 +318,8 @@ class HttpStreamFactoryImpl::JobController
// Privacy mode that should be used for fetching the resource.
PrivacyMode privacy_mode_;
+ const NetLogWithSource net_log_;
+
base::WeakPtrFactory<JobController> ptr_factory_;
};

Powered by Google App Engine
This is Rietveld 408576698