Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: src/debug/debug.h

Issue 2621953002: [debug] Untangle BreakLocation and DebugInfo (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | src/debug/debug.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.h
diff --git a/src/debug/debug.h b/src/debug/debug.h
index 4f32857c8a0d948aa91a921440a53c120670e9b9..d4096ad4e9b1a71391c1ab5ebf21343d79a81687 100644
--- a/src/debug/debug.h
+++ b/src/debug/debug.h
@@ -86,8 +86,7 @@ enum PromiseDebugActionName {
class BreakLocation {
public:
- static BreakLocation FromFrame(Handle<DebugInfo> debug_info,
- JavaScriptFrame* frame);
+ static BreakLocation FromFrame(StandardFrame* frame);
static void AllAtCurrentStatement(Handle<DebugInfo> debug_info,
JavaScriptFrame* frame,
@@ -454,6 +453,13 @@ class Debug {
void ChangeBreakOnException(ExceptionBreakType type, bool enable);
bool IsBreakOnException(ExceptionBreakType type);
+ // The parameter is either a BreakPointInfo object, or a FixedArray of
+ // BreakPointInfo objects.
+ // Returns an empty handle if no breakpoint is hit, or a FixedArray with all
+ // hit breakpoints.
+ MaybeHandle<FixedArray> GetHitBreakPointObjects(
+ Handle<Object> break_point_objects);
+
// Stepping handling.
void PrepareStep(StepAction step_action);
void PrepareStepIn(Handle<JSFunction> function);
@@ -634,9 +640,9 @@ class Debug {
void ActivateStepOut(StackFrame* frame);
void RemoveDebugInfoAndClearFromShared(Handle<DebugInfo> debug_info);
- Handle<Object> CheckBreakPoints(Handle<DebugInfo> debug_info,
- BreakLocation* location,
- bool* has_break_points = nullptr);
+ MaybeHandle<FixedArray> CheckBreakPoints(Handle<DebugInfo> debug_info,
+ BreakLocation* location,
+ bool* has_break_points = nullptr);
bool IsMutedAtCurrentLocation(JavaScriptFrame* frame);
bool CheckBreakPoint(Handle<Object> break_point_object);
MaybeHandle<Object> CallFunction(const char* name, int argc,
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | src/debug/debug.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698