dashboard/dashboard/services/milo_service.py - Issue 2621803002: Clarify comment about jsonp header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/services/milo_service.py

Issue 2621803002: Clarify comment about jsonp header (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dashboard/dashboard/services/milo_service.py

diff --git a/dashboard/dashboard/services/milo_service.py b/dashboard/dashboard/services/milo_service.py

index 85efff2720e68f4825a243fcd6d99221fe8d553a..a398deb7fd9b19a9b8f4d551c7297ec73d45cc4e 100644

--- a/dashboard/dashboard/services/milo_service.py

+++ b/dashboard/dashboard/services/milo_service.py

@@ -44,7 +44,9 @@ def GetBuildbotBuildInfo(master, builder, build_num):

if response.status_code != 200:

return None

- # Unwrap the gRPC message

+ # Unwrap the gRPC message.

+ # Start by removing the jsonp prefix

+ # (see http://security.stackexchange.com/questions/110539).

resp = json.loads(response.content[5:]) # Remove the jsonp header.

# Decompress and unmarshal the json message.

data = base64.b64decode(resp['data'])

« no previous file with comments | « no previous file | no next file » | no next file with comments »