Source/core/dom/SelectorQuery.cpp - Issue 26218002: ClassRootNodeList should start from rootNode, not the first child of rootNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/SelectorQuery.cpp

Issue 26218002: ClassRootNodeList should start from rootNode, not the first child of rootNode. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/SelectorQuery.cpp

diff --git a/Source/core/dom/SelectorQuery.cpp b/Source/core/dom/SelectorQuery.cpp

index 82baa86acad77a30e9c487db255558d39a121fc0..9084ea52bacd56641e4fa258be46b445e294fa3f 100644

--- a/Source/core/dom/SelectorQuery.cpp

+++ b/Source/core/dom/SelectorQuery.cpp

@@ -67,7 +67,7 @@ public:

explicit ClassRootNodeList(Node* rootNode, const AtomicString& className)

haraken 2013/10/07 07:08:49 Nit: 'explicit' is not needed.

tasak 2013/10/07 07:34:34 Done.

: m_className(className)

, m_rootNode(rootNode)

- , m_currentElement(nextInternal(ElementTraversal::firstWithin(rootNode))) { }

+ , m_currentElement(nextInternal(rootNode && rootNode->isElementNode() ? toElement(rootNode) : ElementTraversal::firstWithin(rootNode))) { }

bool isEmpty() const { return !m_currentElement; }

« no previous file with comments | « LayoutTests/fast/selectors/querySelector-leftmost-selector-matches-rootNode-expected.txt ('k') | no next file » | no next file with comments »