Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2621783003: Fuchsia: Pass a job to launchpad_create() (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Pass a job to launchpad_create() This API will change soon such that passing 0 for the job handle will prevent spawned processes from creating new processes themselves. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/245e62280e286fc9e688ce8c43462aa2095d4280

Patch Set 1 #

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M runtime/bin/process_fuchsia.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M runtime/bin/run_vm_tests_fuchsia.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
3 years, 11 months ago (2017-01-10 18:21:26 UTC) #3
rmacnak
lgtm
3 years, 11 months ago (2017-01-10 18:51:36 UTC) #4
zra
3 years, 11 months ago (2017-01-10 19:01:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
245e62280e286fc9e688ce8c43462aa2095d4280 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698