[Media Router] Add browser tests for showing the dialog

chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/browser_action_test_util.h"
 #include "chrome/browser/media/router/media_router_ui_service.h"
+#include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
 #include "chrome/browser/ui/toolbar/media_router_action.h"
 #include "chrome/browser/ui/toolbar/media_router_action_controller.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_delegate.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/toolbar/app_menu.h"
 #include "chrome/browser/ui/views/toolbar/app_menu_button.h"
 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_action_view.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
 #include "chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/context_menu_params.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_utils.h"
 #include "ui/views/widget/widget.h"
 
 namespace media_router {
 
 class MediaRouterUIBrowserTest : public InProcessBrowserTest {
  public:
   MediaRouterUIBrowserTest()
       : issue_(IssueInfo("title notification",
@@ skipping 15 matching lines @@
         MediaRouterUIService::Get(browser()->profile())->action_controller();
 
     routes_ = {MediaRoute("routeId1", MediaSource("sourceId"), "sinkId1",
                           "description", true, std::string(), true)};
   }
 
   void OpenMediaRouterDialogAndWaitForNewWebContents() {
     content::TestNavigationObserver nav_observer(NULL);
     nav_observer.StartWatchingNewWebContents();
 
-    AppMenuButton* app_menu_button =
-        BrowserView::GetBrowserViewForBrowser(browser())
-            ->toolbar()
-            ->app_menu_button();
+    AppMenuButton* app_menu_button = GetAppMenuButton();
 
     // When the Media Router Action executes, it opens a dialog with web
     // contents to chrome://media-router.
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE,
         base::Bind(&MediaRouterUIBrowserTest::ExecuteMediaRouterAction,
                    base::Unretained(this), app_menu_button));
 
     base::RunLoop run_loop;
     app_menu_button->ShowMenu(false);
@@ skipping 23 matching lines @@
             ComponentToolbarActionsFactory::kMediaRouterActionId);
   }
 
   void SetAlwaysShowActionPref(bool always_show) {
     return ToolbarActionsModel::Get(browser()->profile())
         ->component_migration_helper()
         ->SetComponentActionPref(
             ComponentToolbarActionsFactory::kMediaRouterActionId, always_show);
   }
 
+  AppMenuButton* GetAppMenuButton() {
+    return BrowserView::GetBrowserViewForBrowser(browser())
+        ->toolbar()
+        ->app_menu_button();
+  }
+
  protected:
   ToolbarActionsBar* toolbar_actions_bar_ = nullptr;
 
   Issue issue_;
 
   // A vector of MediaRoutes that includes a local route.
   std::vector<MediaRoute> routes_;
 
   MediaRouterActionController* action_controller_ = nullptr;
 };
@@ skipping 22 matching lines @@
   // Navigate away.
   ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
 
   // The navigation should have removed the previously created dialog.
   // We expect a new dialog WebContents to be created by calling this.
   OpenMediaRouterDialogAndWaitForNewWebContents();
 
   SetAlwaysShowActionPref(false);
 }
 
+IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest, OpenDialogFromContextMenu) {
+  // Start with one tab showing about:blank.
+  ASSERT_EQ(1, browser()->tab_strip_model()->count());
+
+  content::WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  MediaRouterDialogController* dialog_controller =
+      MediaRouterDialogController::GetOrCreateForWebContents(
+          browser()->tab_strip_model()->GetActiveWebContents());
+  content::ContextMenuParams params;
+  params.page_url = web_contents->GetController().GetActiveEntry()->GetURL();
+  TestRenderViewContextMenu menu(web_contents->GetMainFrame(), params);
+  menu.Init();
+
+  ASSERT_TRUE(menu.IsItemPresent(IDC_ROUTE_MEDIA));
+  ASSERT_FALSE(dialog_controller->IsShowingMediaRouterDialog());
+  menu.ExecuteCommand(IDC_ROUTE_MEDIA, 0);
+  EXPECT_TRUE(dialog_controller->IsShowingMediaRouterDialog());
+
+  // Executing the command again should be a no-op, and there should only be one
+  // dialog to close.

[apacible, 2017/01/12 19:06:50]

Suggestion: "...should only be one dialog opened per tab."

[takumif, 2017/01/12 21:44:50]

Done.

+  menu.ExecuteCommand(IDC_ROUTE_MEDIA, 0);
+  EXPECT_TRUE(dialog_controller->IsShowingMediaRouterDialog());
+  dialog_controller->HideMediaRouterDialog();
+  EXPECT_FALSE(dialog_controller->IsShowingMediaRouterDialog());
+}
+
+IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest, OpenDialogFromAppMenu) {
+  // Start with one tab showing about:blank.
+  ASSERT_EQ(1, browser()->tab_strip_model()->count());
+
+  AppMenuButton* menu_button = GetAppMenuButton();
+  base::RunLoop run_loop;
+  menu_button->ShowMenu(false);
+  run_loop.RunUntilIdle();
+
+  MediaRouterDialogController* dialog_controller =
+      MediaRouterDialogController::GetOrCreateForWebContents(
+          browser()->tab_strip_model()->GetActiveWebContents());
+  AppMenu* menu = menu_button->app_menu_for_testing();
+  ASSERT_FALSE(dialog_controller->IsShowingMediaRouterDialog());
+  menu->ExecuteCommand(IDC_ROUTE_MEDIA, 0);
+  EXPECT_TRUE(dialog_controller->IsShowingMediaRouterDialog());
+
+  // Executing the command again should be a no-op, and there should only be one
+  // dialog to close.
+  menu->ExecuteCommand(IDC_ROUTE_MEDIA, 0);
+  EXPECT_TRUE(dialog_controller->IsShowingMediaRouterDialog());
+  dialog_controller->HideMediaRouterDialog();
+  EXPECT_FALSE(dialog_controller->IsShowingMediaRouterDialog());
+}
+
+IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest, OpenDialogsInMultipleTabs) {
+  // Start with two tabs.
+  chrome::NewTab(browser());
+  ASSERT_EQ(2, browser()->tab_strip_model()->count());
+  MediaRouterDialogController* dialog_controller1 =
+      MediaRouterDialogController::GetOrCreateForWebContents(
+          browser()->tab_strip_model()->GetWebContentsAt(0));
+  MediaRouterDialogController* dialog_controller2 =
+      MediaRouterDialogController::GetOrCreateForWebContents(
+          browser()->tab_strip_model()->GetWebContentsAt(1));
+
+  SetAlwaysShowActionPref(true);

[apacible, 2017/01/12 19:06:50]

Is this needed? Why is this different from the other tests added in this CL?

[takumif, 2017/01/12 21:44:50]

This is to show the toolbar action which I use in this test (but not in the
other tests). I've added a comment to mention that.

+
+  // Open a dialog in the first tab using the toolbar action.
+  browser()->tab_strip_model()->ActivateTabAt(0, true);
+  EXPECT_FALSE(dialog_controller1->IsShowingMediaRouterDialog());
+  GetMediaRouterAction()->ExecuteAction(true);
+  EXPECT_TRUE(dialog_controller1->IsShowingMediaRouterDialog());
+
+  // Move to the second tab, which shouldn't have a dialog at first. Open and
+  // close a dialog in that tab.
+  browser()->tab_strip_model()->ActivateTabAt(1, true);
+  EXPECT_FALSE(dialog_controller2->IsShowingMediaRouterDialog());
+  GetMediaRouterAction()->ExecuteAction(true);
+  EXPECT_TRUE(dialog_controller2->IsShowingMediaRouterDialog());
+  GetMediaRouterAction()->ExecuteAction(true);
+  EXPECT_FALSE(dialog_controller2->IsShowingMediaRouterDialog());
+
+  // Move back to the first tab, whose dialog should still be open. Hide the
+  // dialog.
+  browser()->tab_strip_model()->ActivateTabAt(0, true);
+  EXPECT_TRUE(dialog_controller1->IsShowingMediaRouterDialog());
+  GetMediaRouterAction()->ExecuteAction(true);
+  EXPECT_FALSE(dialog_controller1->IsShowingMediaRouterDialog());
+
+  SetAlwaysShowActionPref(false);
+}
+
 IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest,
                        EphemeralToolbarIconForRoutesAndIssues) {
   action_controller_->OnIssue(issue_);
   EXPECT_TRUE(ActionExists());
   action_controller_->OnIssuesCleared();
   EXPECT_FALSE(ActionExists());
 
   action_controller_->OnRoutesUpdated(routes_, std::vector<MediaRoute::Id>());
   EXPECT_TRUE(ActionExists());
   action_controller_->OnRoutesUpdated(std::vector<MediaRoute>(),
@@ skipping 52 matching lines @@
   action_controller_->OnRoutesUpdated(std::vector<MediaRoute>(),
                                       std::vector<MediaRoute::Id>());
   EXPECT_FALSE(ActionExists());
   action_controller_->OnRoutesUpdated(routes_, std::vector<MediaRoute::Id>());
   EXPECT_TRUE(ActionExists());
   browser2->window()->Close();
   EXPECT_TRUE(ActionExists());
 }
 
 }  // namespace media_router