Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: chrome/installer/util/browser_distribution.cc

Issue 2621713004: Remove *BinariesDistribution and ChromeBinariesOperations from installer_util. (Closed)
Patch Set: sync to position 442533 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/browser_distribution.cc
diff --git a/chrome/installer/util/browser_distribution.cc b/chrome/installer/util/browser_distribution.cc
index 82e8977d9c2f71093ace1dfea966ef7473837cc5..8e83dda2763a30bbbe12d3f18791837939e726d2 100644
--- a/chrome/installer/util/browser_distribution.cc
+++ b/chrome/installer/util/browser_distribution.cc
@@ -21,8 +21,6 @@
#include "chrome/common/chrome_icon_resources_win.h"
#include "chrome/common/env_vars.h"
#include "chrome/installer/util/app_registration_data.h"
-#include "chrome/installer/util/chromium_binaries_distribution.h"
-#include "chrome/installer/util/google_chrome_binaries_distribution.h"
#include "chrome/installer/util/google_chrome_distribution.h"
#include "chrome/installer/util/google_chrome_sxs_distribution.h"
#include "chrome/installer/util/install_util.h"
@@ -43,8 +41,6 @@ const wchar_t kCommandExecuteImplUuid[] =
// The BrowserDistribution objects are never freed.
BrowserDistribution* g_browser_distribution = NULL;
-BrowserDistribution* g_binaries_distribution = NULL;
-
BrowserDistribution::Type GetCurrentDistributionType() {
return BrowserDistribution::CHROME_BROWSER;
}
@@ -84,34 +80,21 @@ BrowserDistribution* BrowserDistribution::GetDistribution() {
// static
BrowserDistribution* BrowserDistribution::GetSpecificDistribution(
robertshield 2017/01/10 14:49:30 This method shrinking makes me so happy.
grt (UTC plus 2) 2017/01/10 19:54:41 How happy will you be if I remove BrowserDistribut
BrowserDistribution::Type type) {
+ DCHECK_EQ(type, CHROME_BROWSER);
BrowserDistribution* dist = NULL;
- switch (type) {
- case CHROME_BROWSER:
-#if defined(GOOGLE_CHROME_BUILD)
- if (InstallUtil::IsChromeSxSProcess()) {
- dist = GetOrCreateBrowserDistribution<GoogleChromeSxSDistribution>(
- &g_browser_distribution);
- } else {
- dist = GetOrCreateBrowserDistribution<GoogleChromeDistribution>(
- &g_browser_distribution);
- }
-#else
- dist = GetOrCreateBrowserDistribution<BrowserDistribution>(
- &g_browser_distribution);
-#endif
- break;
-
- default:
- DCHECK_EQ(CHROME_BINARIES, type);
#if defined(GOOGLE_CHROME_BUILD)
- dist = GetOrCreateBrowserDistribution<GoogleChromeBinariesDistribution>(
- &g_binaries_distribution);
+ if (InstallUtil::IsChromeSxSProcess()) {
+ dist = GetOrCreateBrowserDistribution<GoogleChromeSxSDistribution>(
+ &g_browser_distribution);
+ } else {
+ dist = GetOrCreateBrowserDistribution<GoogleChromeDistribution>(
+ &g_browser_distribution);
+ }
#else
- dist = GetOrCreateBrowserDistribution<ChromiumBinariesDistribution>(
- &g_binaries_distribution);
+ dist = GetOrCreateBrowserDistribution<BrowserDistribution>(
+ &g_browser_distribution);
#endif
- }
return dist;
}

Powered by Google App Engine
This is Rietveld 408576698