Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: chrome/installer/util/chrome_binaries_operations.cc

Issue 2621713004: Remove *BinariesDistribution and ChromeBinariesOperations from installer_util. (Closed)
Patch Set: sync to position 442533 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/chrome_binaries_operations.cc
diff --git a/chrome/installer/util/chrome_binaries_operations.cc b/chrome/installer/util/chrome_binaries_operations.cc
deleted file mode 100644
index 63d8f938c1bc58a305c8cc92ba97be49acf7ff97..0000000000000000000000000000000000000000
--- a/chrome/installer/util/chrome_binaries_operations.cc
+++ /dev/null
@@ -1,91 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/installer/util/chrome_binaries_operations.h"
-
-#include "base/command_line.h"
-#include "base/files/file_path.h"
-#include "base/logging.h"
-#include "chrome/installer/util/channel_info.h"
-#include "chrome/installer/util/helper.h"
-#include "chrome/installer/util/master_preferences.h"
-#include "chrome/installer/util/master_preferences_constants.h"
-#include "chrome/installer/util/util_constants.h"
-
-namespace installer {
-
-void ChromeBinariesOperations::ReadOptions(const MasterPreferences& prefs,
- std::set<base::string16>* options)
- const {
- DCHECK(options);
- options->insert(kOptionMultiInstall);
-}
-
-void ChromeBinariesOperations::ReadOptions(
- const base::CommandLine& uninstall_command,
- std::set<base::string16>* options) const {
- DCHECK(options);
- options->insert(kOptionMultiInstall);
-}
-
-void ChromeBinariesOperations::AddKeyFiles(
- const std::set<base::string16>& options,
- std::vector<base::FilePath>* key_files) const {
- DCHECK(key_files);
- key_files->push_back(base::FilePath(installer::kChromeDll));
-}
-
-void ChromeBinariesOperations::AppendProductFlags(
- const std::set<base::string16>& options,
- base::CommandLine* cmd_line) const {
- DCHECK(cmd_line);
-
- DCHECK(options.find(kOptionMultiInstall) != options.end());
-
- // Add --multi-install if it isn't already there.
- if (!cmd_line->HasSwitch(switches::kMultiInstall))
- cmd_line->AppendSwitch(switches::kMultiInstall);
-}
-
-void ChromeBinariesOperations::AppendRenameFlags(
- const std::set<base::string16>& options,
- base::CommandLine* cmd_line) const {
- DCHECK(cmd_line);
-
- DCHECK(options.find(kOptionMultiInstall) != options.end());
-
- // Add --multi-install if it isn't already there.
- if (!cmd_line->HasSwitch(switches::kMultiInstall))
- cmd_line->AppendSwitch(switches::kMultiInstall);
-}
-
-bool ChromeBinariesOperations::SetChannelFlags(
- const std::set<base::string16>& options,
- bool set,
- ChannelInfo* channel_info) const {
- return false;
-}
-
-bool ChromeBinariesOperations::ShouldCreateUninstallEntry(
- const std::set<base::string16>& options) const {
- return false;
-}
-
-void ChromeBinariesOperations::AddDefaultShortcutProperties(
- BrowserDistribution* dist,
- const base::FilePath& target_exe,
- ShellUtil::ShortcutProperties* properties) const {
- NOTREACHED() << "Chrome Binaries do not create shortcuts.";
-}
-
-void ChromeBinariesOperations::LaunchUserExperiment(
- const base::FilePath& setup_path,
- const std::set<base::string16>& options,
- InstallStatus status,
- bool system_level) const {
- // Not meaningful to have binaries run experiments.
- NOTREACHED();
-}
-
-} // namespace installer

Powered by Google App Engine
This is Rietveld 408576698