Source/core/html/HTMLTableRowElement.cpp - Issue 262163008: HTMLTableSectionElement.insertRow(0) / HTMLTableRowElement.insertCell(0) do not behave correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTableRowElement.cpp

Issue 262163008: HTMLTableSectionElement.insertRow(0) / HTMLTableRowElement.insertCell(0) do not behave correctly (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix nits Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLTableSectionElement/insertRow-skips-non-tr-expected.txt ('k') | Source/core/html/HTMLTableSectionElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTableRowElement.cpp

diff --git a/Source/core/html/HTMLTableRowElement.cpp b/Source/core/html/HTMLTableRowElement.cpp

index 0e63ab98b32b7f910982630962dcb6ad32f9e0d5..93c6fecfae8b6e92997141346ea9e907aa90d545 100644

--- a/Source/core/html/HTMLTableRowElement.cpp

+++ b/Source/core/html/HTMLTableRowElement.cpp

@@ -135,16 +135,10 @@ PassRefPtr<HTMLElement> HTMLTableRowElement::insertCell(int index, ExceptionStat

}

RefPtr<HTMLTableCellElement> cell = HTMLTableCellElement::create(tdTag, document());

- if (index < 0 || index >= numCells)

+ if (numCells == index || index == -1)

appendChild(cell, exceptionState);

- else {

- Node* n;

- if (index < 1)

- n = firstChild();

- else

- n = children->item(index);

- insertBefore(cell, n, exceptionState);

- }

+ else

+ insertBefore(cell, children->item(index), exceptionState);

return cell.release();

}