Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: Source/core/html/HTMLTableSectionElement.cpp

Issue 262163008: HTMLTableSectionElement.insertRow(0) / HTMLTableRowElement.insertCell(0) do not behave correctly (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix descriptions Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLTableSectionElement.cpp
diff --git a/Source/core/html/HTMLTableSectionElement.cpp b/Source/core/html/HTMLTableSectionElement.cpp
index 30af275fb286ad5abe094adbc35317c2e21e542d..35644d2699128298400ed55c2444bbda185caefd 100644
--- a/Source/core/html/HTMLTableSectionElement.cpp
+++ b/Source/core/html/HTMLTableSectionElement.cpp
@@ -76,7 +76,7 @@ PassRefPtr<HTMLElement> HTMLTableSectionElement::insertRow(int index, ExceptionS
if (numRows == index || index == -1) {
appendChild(row, exceptionState);
} else {
- Node* n = index ? children->item(index) : firstChild();
+ Element* n = children->item(index);
tkent 2014/05/07 01:18:23 nit: We can remove the local variable |n| and fold
Inactive 2014/05/07 01:37:13 Done.
insertBefore(row, n, exceptionState);
}
return row.release();
« Source/core/html/HTMLTableRowElement.cpp ('K') | « Source/core/html/HTMLTableRowElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698