Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/test-api.cc

Issue 262163006: Removed default Isolate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/cctest.cc ('k') | test/cctest/test-microtask-delivery.cc » ('j') | test/cctest/test-microtask-delivery.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index df70d5c5f8865025004c1f07f08f94298516068c..1dd433779b4b9e8ceb598506e5cdc8d9d281d3e3 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -19269,7 +19269,6 @@ TEST(IsolateNewDispose) {
v8::Isolate* current_isolate = CcTest::isolate();
v8::Isolate* isolate = v8::Isolate::New();
CHECK(isolate != NULL);
- CHECK(!reinterpret_cast<i::Isolate*>(isolate)->IsDefaultIsolate());
CHECK(current_isolate != isolate);
CHECK(current_isolate == CcTest::isolate());
@@ -22339,6 +22338,7 @@ TEST(EventLogging) {
TEST(Promises) {
i::FLAG_harmony_promises = true;
+ i::FLAG_harmony_weak_collections = true; // Implied
dcarney 2014/05/06 11:38:35 wtf?
LocalContext context;
v8::Isolate* isolate = context->GetIsolate();
« no previous file with comments | « test/cctest/cctest.cc ('k') | test/cctest/test-microtask-delivery.cc » ('j') | test/cctest/test-microtask-delivery.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698