Issue 262163006: Removed default Isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262163006: Removed default Isolate. (Closed)

Created:
6 years, 7 months ago by Sven Panne

Modified:
6 years, 7 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Removed default Isolate. There is probably room for more cleanup after this... BUG=359977 LOG=y R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21167

Patch Set 2 : Rebased #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -78 lines)			Patch
M	src/api.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/d8.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/isolate.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/isolate.cc	View	4 chunks	+2 lines, -11 lines	0 comments	Download
M	src/log.cc	View	1 chunk	+33 lines, -43 lines	0 comments	Download
M	src/mksnapshot.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/v8.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	test/cctest/cctest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	test/cctest/test-microtask-delivery.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dcarney

lgtm, with wtfs https://codereview.chromium.org/262163006/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/262163006/diff/1/test/cctest/test-api.cc#newcode22341 test/cctest/test-api.cc:22341: i::FLAG_harmony_weak_collections = true; // Implied wtf? ...

6 years, 7 months ago (2014-05-06 11:38:35 UTC) #2

Sven Panne

6 years, 7 months ago (2014-05-06 11:48:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21167 (presubmit successful).

Expand Messages | Collapse Messages

Issue 262163006: Removed default Isolate. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Messages