[Ozone] Proper cursor support for multi-monitor configurations

[Ozone] Proper cursor support for multi-monitor configurations

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268877

[dnicoara, 2014-05-05 17:37:18]

https://codereview.chromium.org/262163003/diff/20001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/262163003/diff/20001/ui/events/event.h#newcode79
ui/events/event.h:79: gfx::AcceleratedWidget window() const { return window_; }
I'm also wondering if this could be moved into one of the other Ozone factories?

[dnicoara, 2014-05-05 19:36:31]

Based on talking to sadrul, it looks like this will be a temporary solution
until WindowTreeHost::CanDispatchEvent() gets removed.

PTAL

[spang, 2014-05-06 19:41:25]

https://codereview.chromium.org/262163003/diff/60001/ui/ozone/platform/dri/cu...
File ui/ozone/platform/dri/cursor_factory_evdev_dri.cc (right):

https://codereview.chromium.org/262163003/diff/60001/ui/ozone/platform/dri/cu...
ui/ozone/platform/dri/cursor_factory_evdev_dri.cc:44:
dri_->UnsetHardwareCursor(cursor_window_);
why is this needed?

don't we get a SetCursor(None) ?

[spang, 2014-05-06 20:18:32]

lgtm

[dnicoara, 2014-05-06 21:03:42]

https://codereview.chromium.org/262163003/diff/60001/ui/ozone/platform/dri/cu...
File ui/ozone/platform/dri/cursor_factory_evdev_dri.cc (right):

https://codereview.chromium.org/262163003/diff/60001/ui/ozone/platform/dri/cu...
ui/ozone/platform/dri/cursor_factory_evdev_dri.cc:44:
dri_->UnsetHardwareCursor(cursor_window_);
On 2014/05/06 19:41:26, spang wrote:
> why is this needed?
> 
> don't we get a SetCursor(None) ?

Nope, the cursor is never hidden on the original window.

[sadrul, 2014-05-07 14:02:06]

LGTM (I was going to suggest using something other than 'active' in
'GetActiveWindow()', perhaps 'GetCursorWindow()', since 'active' means something
else in aura, but considering this is expected to be temporary, this seems OK)

[dnicoara, 2014-05-07 15:23:53]

On 2014/05/07 14:02:06, sadrul wrote:
> LGTM (I was going to suggest using something other than 'active' in
> 'GetActiveWindow()', perhaps 'GetCursorWindow()', since 'active' means
something
> else in aura, but considering this is expected to be temporary, this seems OK)

Done.

[dnicoara, 2014-05-07 16:31:52]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2014-05-07 16:33:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dnicoara@chromium.org/262163003/80001

[commit-bot: I haz the power, 2014-05-07 18:46:40]

Change committed as 268877