Issue 26216003: Fix History.{push,replace}State handling of null 'url' argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26216003: Fix History.{push,replace}State handling of null 'url' argument (Closed)

Created:
7 years, 2 months ago by Jens Widell

Modified:
7 years, 2 months ago

Reviewers:
arv (Not doing code reviews), abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix History.{push,replace}State handling of null 'url' argument According to the specification[1], if the 'url' argument is null, the new URL should be the URL of the current entry. A relative URL should be resolved using the document's base URL. Adjust History::urlForState() to not treat a null (isNull()) string the same as an empty (isEmpty()) string, which it otherwise does since isEmpty() returns true for null strings as well. BUG=279278 [1] http://www.whatwg.org/specs/web-apps/current-work/#dom-history-pushstate Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159120

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -4 lines)			Patch
A	LayoutTests/http/tests/navigation/replacestate-base-no-url-argument.html	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/navigation/replacestate-base-no-url-argument-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	LayoutTests/http/tests/navigation/resources/replacestate-base-no-url-argument.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/History.cpp	View	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/26216003/1

7 years, 2 months ago (2013-10-08 14:36:48 UTC) #4

Message was sent while issue was closed.

Change committed as 159120

Expand Messages | Collapse Messages