Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2621583003: Status update: profiler tests pass on windows x64 debug, but one crashes on (Closed)

Created:
3 years, 11 months ago by regis
Modified:
3 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Status update: profiler tests pass on windows x64 debug, but one crashes on mac debug x64. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/f5c80237e352e06b2e1d07499529f087d0cd0047

Patch Set 1 #

Patch Set 2 : work in progress #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 11 months ago (2017-01-09 21:36:38 UTC) #2
zra
lgtm
3 years, 11 months ago (2017-01-09 21:39:42 UTC) #3
regis
3 years, 11 months ago (2017-01-09 21:43:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f5c80237e352e06b2e1d07499529f087d0cd0047 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698