pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart - Issue 2621543004: Cleanup references to the old DDC repo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

Issue 2621543004: Cleanup references to the old DDC repo (Closed)

Patch Set: Linkify issues Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

index 913107e0e48628a8026af6ee3120ea2979f8cef1..154410e6b20f43ce552c3fa4993d53cea0537470 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

@@ -98,7 +98,7 @@ copyProperty(to, from, name) {

// On native types, Symbol.iterator may already be present.

// TODO(jmesserly): investigate if we still need this.

// If so, we need to find a better solution.

- // See: https://github.com/dart-lang/dev_compiler/issues/487

+ // See https://github.com/dart-lang/sdk/issues/28324

var existing = getOwnPropertyDescriptor(to, name);

if (existing != null) {

if (JS('bool', '#.writable', existing)) {