pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart - Issue 2621543004: Cleanup references to the old DDC repo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Issue 2621543004: Cleanup references to the old DDC repo (Closed)

Patch Set: Linkify issues Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

index cefbefb19e5030b55c82852aaa82e14b3f1bef80..629ae6b05d79c79e2824a759db5ef874bbb855c9 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

@@ -761,7 +761,7 @@ String _toString(obj) {

}

// TODO(jmesserly): restore this faster path once ES Symbol is treated as

// an extension type (and thus hits the above code path).

- // See https://github.com/dart-lang/dev_compiler/issues/578.

+ // See https://github.com/dart-lang/sdk/issues/28323

// return JS('', '"" + #', obj);

return JS('String', '#.toString()', obj);

}