Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2621543004: Cleanup references to the old DDC repo (Closed)
Patch Set: Linkify issues Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/module_builder.dart ('k') | pkg/dev_compiler/test/codegen/js_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/test/browser/language_tests.js
diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js
index 4266b3c9bfd2fac226bbd7d03ef12642d163b167..ad222628d0894c0740c755e496556627dc61fc11 100644
--- a/pkg/dev_compiler/test/browser/language_tests.js
+++ b/pkg/dev_compiler/test/browser/language_tests.js
@@ -52,7 +52,10 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'assertion_test': skip_fail,
'async_await_test_none_multi': 'unittest',
'async_await_test_02_multi': 'unittest',
- 'async_await_test_03_multi': skip_fail, // Flaky on travis (#634)
+
+ // Flaky on travis (https://github.com/dart-lang/sdk/issues/27224)
+ 'async_await_test_03_multi': skip_fail,
+
'async_star_await_pauses_test': skip_fail,
// TODO(jmesserly): figure out why this test is hanging.
@@ -61,8 +64,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'async_star_cancel_while_paused_test': skip_fail,
'async_star_regression_fisk_test': skip_fail,
- // TODO(vsm): Re-enable.
- // See https://github.com/dart-lang/dev_compiler/issues/456
+ // TODO(vsm): Re-enable (https://github.com/dart-lang/sdk/issues/28319)
'async_star_test_none_multi': ['unittest', 'skip', 'fail'],
'async_star_test_01_multi': ['unittest', 'skip', 'fail'],
'async_star_test_02_multi': ['unittest', 'skip', 'fail'],
@@ -95,9 +97,6 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'cha_deopt1_test': skip_fail,
'cha_deopt2_test': skip_fail,
'cha_deopt3_test': skip_fail,
-
- // interpolation does not call Dart's toString:
- // https://github.com/dart-lang/dev_compiler/issues/470
'class_syntax2_test': skip_fail,
'classes_static_method_clash_test': skip_fail,
'closure_call_wrong_argument_count_negative_test': skip_fail,
@@ -407,10 +406,6 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'lib/convert': {
'encoding_test': skip_timeout,
- // TODO(jmesserly): this is in an inconsistent state between our old and
- // newer SDKs.
- 'html_escape_test': ['skip'],
-
'json_utf8_chunk_test': skip_timeout,
'latin1_test': skip_timeout,
@@ -425,7 +420,10 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'lib/html': {
'async_spawnuri_test': async_unittest,
'async_test': async_unittest,
- 'audiocontext_test': is.chrome('<=54') ? fail : pass, // was sdk#27578, needs triage
+
+ // was https://github.com/dart-lang/sdk/issues/27578, needs triage
+ 'audiocontext_test': is.chrome('<=54') ? fail : pass,
+
'canvas_test': ['unittest'],
'canvasrenderingcontext2d_test': ['unittest'],
'cross_domain_iframe_test': async_unittest,
@@ -435,17 +433,24 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
// This is failing with a range error, I'm guessing because it's looking
// for a stylesheet and the page has none.
'css_rule_list_test': 'fail',
+
'custom_element_method_clash_test': async_unittest,
'custom_element_name_clash_test': async_unittest,
'custom_elements_23127_test': async_unittest,
'custom_elements_test': async_unittest,
- 'dom_constructors_test': 'fail', // was sdk#27578, needs triage
+
+ // was https://github.com/dart-lang/sdk/issues/27578, needs triage
+ 'dom_constructors_test': 'fail',
+
'element_animate_test': async_unittest,
- 'element_classes_test': 'fail', // sdk#27579.
- 'element_classes_svg_test': 'fail', // sdk#27579.
+
+ // https://github.com/dart-lang/sdk/issues/27579.
+ 'element_classes_test': 'fail',
+ 'element_classes_svg_test': 'fail',
// Failure: 'Expected 56 to be in the inclusive range [111, 160].'.
'element_offset_test': 'fail',
+
'element_test': async_unittest,
'element_types_test': firefox_fail,
'event_customevent_test': async_unittest,
@@ -454,12 +459,14 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
// Failure: "Failed to execute 'dispatchEvent' on 'EventTarget': parameter
// 1 is not of type 'Event'."
'event_test': 'fail',
+
'fileapi_test': async_unittest,
'filereader_test': async_unittest,
'fontface_loaded_test': async_unittest,
// Failed because it's expecting "Ahem" but getting null. Maybe sdk#27579?
'fontface_test': 'fail',
+
'form_data_test': async_unittest,
'history_test': async_unittest,
'indexeddb_1_test': async_unittest,
@@ -467,7 +474,10 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'indexeddb_3_test': async_unittest,
'indexeddb_4_test': async_unittest,
'indexeddb_5_test': async_unittest,
- 'input_element_test': 'fail', // was sdk#27578, needs triage
+
+ // was https://github.com/dart-lang/sdk/issues/27578, needs triage
+ 'input_element_test': 'fail',
+
'interactive_test': async_unittest,
'isolates_test': async_unittest,
@@ -480,29 +490,41 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'js_util_test': 'fail',
'keyboard_event_test': async_unittest,
- 'mediasource_test': 'fail', // was sdk#27578, needs triage
- 'media_stream_test': 'fail', // was sdk#27578, needs triage
- 'messageevent_test': 'fail', // was sdk#27578, needs triage
+ // was https://github.com/dart-lang/sdk/issues/27578, needs triage
+ 'mediasource_test': 'fail',
+ 'media_stream_test': 'fail',
+ 'messageevent_test': 'fail',
// Should throw but does not.
'mirrors_js_typed_interop_test': 'fail',
'mutationobserver_test': async_unittest,
'native_gc_test': async_unittest,
- 'notification_test': 'fail', // was sdk#27578, needs triage
+
+ // was https://github.com/dart-lang/sdk/issues/27578, needs triage
+ 'notification_test': 'fail',
+
'postmessage_structured_test': async_unittest,
'queryall_test': ['slow'], // see sdk #27794
'request_animation_frame_test': async_unittest,
'resource_http_test': async_unittest,
- 'rtc_test': is.chrome('<=55') ? fail : pass, // was sdk#27578, needs triage
+
+ // was https://github.com/dart-lang/sdk/issues/27578, needs triage
+ 'rtc_test': is.chrome('<=55') ? fail : pass,
// Expected 1, got null.
'serialized_script_value_test': 'fail',
+
'shadow_dom_test': firefox_fail,
- 'speechrecognition_test': 'fail', // was sdk#27578, needs triage
- 'svgelement_test': chrome_fail, // was sdk#27578, needs triage
+
+ // was https://github.com/dart-lang/sdk/issues/27578, needs triage
+ 'speechrecognition_test': 'fail',
+ 'svgelement_test': chrome_fail,
'text_event_test': firefox_fail,
- 'touchevent_test': 'fail', // was sdk#27578, needs triage
+
+ // was https://github.com/dart-lang/sdk/issues/27578, needs triage
+ 'touchevent_test': 'fail',
+
'transferables_test': async_unittest,
'transition_event_test': async_unittest,
'url_test': async_unittest,
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/module_builder.dart ('k') | pkg/dev_compiler/test/codegen/js_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698