Chromium Code Reviews| Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart |
| diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart |
| index d4069072afdc15a04bf9e717848d7a34c0434d1a..2ba5d9b92a5d05fed722a949b8fc37bacd3a8e2c 100644 |
| --- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart |
| +++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart |
| @@ -1331,7 +1331,7 @@ class CodeGenerator extends GeneralizingAstVisitor |
| // bypass the ES6 restrictions. |
| // |
| // TODO(jmesserly): we'll need to rethink this. |
| - // See <https://github.com/dart-lang/dev_compiler/issues/51>. |
| + // See #28322. |
|
Jennifer Messerly
2017/01/10 19:01:18
nit: I try and use full bug links because they're
vsm
2017/01/10 20:55:27
Good point. Done here and elsewhere. Also makes
|
| // This level of indirection will hurt performance. |
| jsMethods.add(new JS.Method( |
| _propertyName('constructor'), |
| @@ -2292,8 +2292,7 @@ class CodeGenerator extends GeneralizingAstVisitor |
| } |
| } |
| - // TODO(jmesserly): various problems here, see: |
| - // https://github.com/dart-lang/dev_compiler/issues/116 |
| + // TODO(jmesserly): various problems here, see: #27259 |
| var paramType = |
| resolutionMap.elementDeclaredByFormalParameter(param).type; |
| if (node is MethodDeclaration && |
| @@ -2648,8 +2647,7 @@ class CodeGenerator extends GeneralizingAstVisitor |
| // are not mutated inside the generator. |
| // |
| // In the future, we might be able to simplify this, see: |
| - // https://github.com/dart-lang/dev_compiler/issues/247. |
| - // |
| + // https://github.com/dart-lang/sdk#28320 |
|
Jennifer Messerly
2017/01/10 19:01:18
this link is broken, it should be
https://github
vsm
2017/01/10 20:55:27
Done.
|
| // `async` works the same, but uses the `dart.async` helper. |
| // |
| // In the body of a `sync*` and `async`, `yield`/`await` are both generated |
| @@ -2956,8 +2954,7 @@ class CodeGenerator extends GeneralizingAstVisitor |
| var typeFormals = type.typeFormals; |
| if (typeFormals.isNotEmpty && !lowerTypedef) { |
| // TODO(jmesserly): this is a suboptimal representation for universal |
| - // function types (as callable functions). See discussion at: |
| - // https://github.com/dart-lang/dev_compiler/issues/526 |
| + // function types (as callable functions). See discussion at #27333 |
| var tf = _emitTypeFormals(typeFormals); |
| var names = _typeTable.discharge(typeFormals); |
| var parts = new JS.ArrayInitializer(typeParts); |
| @@ -5643,7 +5640,6 @@ class CodeGenerator extends GeneralizingAstVisitor |
| expectedType = types.streamType; |
| } else { |
| // Future<T> -> T |
| - // TODO(vsm): Revisit with issue #228. |
| expectedType = types.futureType; |
| } |
| } else { |