Issue 262153002: Revert of Make it possible to build libhardware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262153002: Revert of Make it possible to build libhardware. (Closed)

Created:
6 years, 7 months ago by DaleCurtis

Modified:
6 years, 7 months ago

Reviewers:
rjkroege, fjhenigman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@hwc2

Visibility:
Public.

Revert of Make it possible to build libhardware. (https://codereview.chromium.org/252583002/) Reason for revert: Broke check_licenses, since hwcplus_util.c doesn't have a license. Please add one. http://build.chromium.org/p/chromium/builders/Linux/builds/49510/steps/check_licenses/logs/stdio Original issue's description: > Make it possible to build libhardware. > > Fix up some include files, supply some stubs, and make the hardware > module search path configurable at compile time and run time. > > BUG=358029 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268096 TBR=rjkroege@chromium.org,fjhenigman@chromium.org NOTREECHECKS=true NOTRY=true BUG=358029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268112

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -120 lines)			Patch
M	third_party/hwcplus/include/cutils/properties.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	third_party/hwcplus/include/hardware/hardware.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	third_party/hwcplus/include/log/log.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	third_party/hwcplus/include/system/graphics.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	third_party/hwcplus/src/hardware.c	View	2 chunks	+7 lines, -27 lines	0 comments	Download
D	third_party/hwcplus/src/hwcplus_util.c	View	1 chunk	+0 lines, -71 lines	0 comments	Download

Total messages: 4 (0 generated)

DaleCurtis

Created Revert of Make it possible to build libhardware.

6 years, 7 months ago (2014-05-04 18:30:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/262153002/1

6 years, 7 months ago (2014-05-04 18:30:22 UTC) #3

Message was sent while issue was closed.

Change committed as 268112