Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: content/browser/resources/media/peer_connection_update_table.js

Issue 2621493002: webrtc-internals: highlight failures (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/resources/media/webrtc_internals.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/resources/media/peer_connection_update_table.js
diff --git a/content/browser/resources/media/peer_connection_update_table.js b/content/browser/resources/media/peer_connection_update_table.js
index f3475a8174a938143caca6d76b5a3041533aad20..fc18a2ca95fccbd48c935c0a813b3f1b583b544b 100644
--- a/content/browser/resources/media/peer_connection_update_table.js
+++ b/content/browser/resources/media/peer_connection_update_table.js
@@ -106,6 +106,13 @@ var PeerConnectionUpdateTable = (function() {
var details = row.cells[1].childNodes[0];
details.appendChild(valueContainer);
+ // Highlight ICE failures and failure callbacks.
+ if ((update.type === 'iceConnectionStateChange' &&
+ update.value === 'ICEConnectionStateFailed') ||
tommi (sloooow) - chröme 2017/01/08 16:48:05 nit: indent one more space to group with the above
fippo 2017/01/08 17:10:01 Done.
+ update.type.indexOf('OnFailure') !== -1) {
+ valueContainer.parentElement.classList.add('update-log-failure');
+ }
+
var value = update.value;
// map internal names and values to names and events from the
// specification. This is a display change which shall not
« no previous file with comments | « no previous file | content/browser/resources/media/webrtc_internals.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698