webrtc-internals: highlight failures

content/browser/resources/media/peer_connection_update_table.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * The data of a peer connection update.
  * @param {number} pid The id of the renderer.
  * @param {number} lid The id of the peer conneciton inside a renderer.
  * @param {string} type The type of the update.
@@ skipping 88 matching lines @@
         return;
       }
 
       row.innerHTML += '<td><details><summary>' + type +
           '</summary></details></td>';
 
       var valueContainer = document.createElement('pre');
       var details = row.cells[1].childNodes[0];
       details.appendChild(valueContainer);
 
+      // Highlight ICE failures and failure callbacks.
+      if ((update.type === 'iceConnectionStateChange' &&
+          update.value === 'ICEConnectionStateFailed') ||

[tommi (sloooow) - chröme, 2017/01/08 16:48:05]

nit: indent one more space to group with the above condition

[fippo, 2017/01/08 17:10:01]

Done.

+          update.type.indexOf('OnFailure') !== -1) {
+        valueContainer.parentElement.classList.add('update-log-failure');
+      }
+
       var value = update.value;
       // map internal names and values to names and events from the
       // specification. This is a display change which shall not
       // change the JSON dump.
       if (update.type === 'iceConnectionStateChange') {
         value = {
           ICEConnectionStateNew: 'new',
           ICEConnectionStateChecking: 'checking',
           ICEConnectionStateConnected: 'connected',
           ICEConnectionStateCompleted: 'completed',
@@ skipping 43 matching lines @@
         tableContainer.appendChild(tableElement);
         tableElement.innerHTML = '<tr><th>Time</th>' +
             '<th class="update-log-header-event">Event</th></tr>';
       }
       return tableElement;
     }
   };
 
   return PeerConnectionUpdateTable;
 })();