Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 2621343002: VM: [Kernel] Add kernel::ConstantEvaluator support for string.length (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Add kernel::ConstantEvaluator support for string.length R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/bce0be454039730826553a8144a3c3916fb8e49e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M runtime/vm/kernel_to_il.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
3 years, 11 months ago (2017-01-11 15:30:22 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 11 months ago (2017-01-11 17:17:39 UTC) #3
kustermann
3 years, 11 months ago (2017-01-11 18:54:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bce0be454039730826553a8144a3c3916fb8e49e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698