Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2621303004: Keep track of coalesced events in main thread event queue (Closed)
Patch Set: Keep coalesced events in main thread event queue unittests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 3eefe298696687b36544eed2852c4e7256813907..e399efa465a70c1c34b7b800ed5b8a7885a14a73 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -961,7 +961,7 @@ WebInputEventResult WebViewImpl::handleSyntheticWheelFromTouchpadPinchEvent(
wheelEvent.wheelTicksX = 0;
wheelEvent.wheelTicksY = pinchEvent.data.pinchUpdate.scale > 1 ? 1 : -1;
- return handleInputEvent(wheelEvent);
+ return handleInputEvent(blink::WebCoalescedInputEvent(wheelEvent));
}
void WebViewImpl::transferActiveWheelFlingAnimation(
@@ -2109,7 +2109,8 @@ bool WebViewImpl::hasVerticalScrollbar() {
const WebInputEvent* WebViewImpl::m_currentInputEvent = nullptr;
WebInputEventResult WebViewImpl::handleInputEvent(
- const WebInputEvent& inputEvent) {
+ const WebCoalescedInputEvent& coalescedEvent) {
+ const WebInputEvent& inputEvent = coalescedEvent.event();
// TODO(dcheng): The fact that this is getting called when there is no local
// main frame is problematic and probably indicates a bug in the input event
// routing code.
@@ -2213,7 +2214,7 @@ WebInputEventResult WebViewImpl::handleInputEvent(
// FIXME: This should take in the intended frame, not the local frame root.
WebInputEventResult result = PageWidgetDelegate::handleInputEvent(
- *this, WebCoalescedInputEvent(inputEvent), mainFrameImpl()->frame());
+ *this, coalescedEvent, mainFrameImpl()->frame());
if (result != WebInputEventResult::NotHandled)
return result;

Powered by Google App Engine
This is Rietveld 408576698