Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerClipper.h

Issue 2621243002: Fix paint offset and clips in SPv2 (Closed)
Patch Set: none Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerClipper.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerClipper.h b/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
index f3dd97d82bd6ce56e4ff0d53320da367072547e8..d8fc4575de32d3abd0ebb9691e44436be5163918 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
@@ -214,10 +214,14 @@ class CORE_EXPORT PaintLayerClipper {
bool shouldClipOverflow(const ClipRectsContext&) const;
bool shouldRespectOverflowClip(const ClipRectsContext&) const;
+ // Returned clip rect is in the space of the context's rootLayer.
ClipRect clipRectWithGeometryMapper(const ClipRectsContext&,
bool isForeground) const;
+ // Mutates the given rect into a rect in the space of the context's
+ // rootLayer.
void mapLocalToRootWithGeometryMapper(const ClipRectsContext&,
- LayoutRect& localRect) const;
+ LayoutRect&) const;
+ // Same as calculateRects, but using GeometryMapper.
void calculateRectsWithGeometryMapper(
const ClipRectsContext&,
const LayoutRect& paintDirtyRect,
@@ -232,6 +236,8 @@ class CORE_EXPORT PaintLayerClipper {
const PaintLayer& m_layer;
std::unique_ptr<GeometryMapper> m_geometryMapper;
+
+ friend class PaintLayerClipperTest;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698