Issue 26212003: android: Fix importing pexpect on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26212003: android: Fix importing pexpect on Mac (Closed)

Created:
7 years, 2 months ago by Sami

Modified:
7 years, 2 months ago

Reviewers:
Torne

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android: Fix importing pexpect on Mac We should use the version of pexpect from pylib to make sure we can import it an all platforms where it is available. BUG=304337 R=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227946

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	build/android/adb_profile_chrome.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/android_commands.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/perf/test_runner.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 2 months ago (2013-10-10 15:37:45 UTC) #3

Sami

7 years, 2 months ago (2013-10-10 16:40:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r227946 (presubmit successful).

Expand Messages | Collapse Messages