Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: runtime/vm/timeline.h

Issue 2621163008: VM: Free [TimelineEventBlock]s before shutting down (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline.h
diff --git a/runtime/vm/timeline.h b/runtime/vm/timeline.h
index 4b4333e02aea8714d0d8ba89e9bc4fe19799d985..c7c6016693bd9489884608cbbb4e415f3cd322a1 100644
--- a/runtime/vm/timeline.h
+++ b/runtime/vm/timeline.h
@@ -681,7 +681,7 @@ class TimelineEventFixedBufferRecorder : public TimelineEventRecorder {
static const intptr_t kDefaultCapacity = 8192;
explicit TimelineEventFixedBufferRecorder(intptr_t capacity);
- ~TimelineEventFixedBufferRecorder();
+ virtual ~TimelineEventFixedBufferRecorder();
void PrintJSON(JSONStream* js, TimelineEventFilter* filter);
void PrintTraceEvent(JSONStream* js, TimelineEventFilter* filter);
@@ -708,7 +708,7 @@ class TimelineEventRingRecorder : public TimelineEventFixedBufferRecorder {
public:
explicit TimelineEventRingRecorder(intptr_t capacity = kDefaultCapacity)
: TimelineEventFixedBufferRecorder(capacity) {}
- ~TimelineEventRingRecorder() {}
+ virtual ~TimelineEventRingRecorder() {}
const char* name() const { return "Ring"; }
@@ -723,8 +723,7 @@ class TimelineEventRingRecorder : public TimelineEventFixedBufferRecorder {
class TimelineEventSystraceRecorder : public TimelineEventFixedBufferRecorder {
public:
explicit TimelineEventSystraceRecorder(intptr_t capacity = kDefaultCapacity);
-
- ~TimelineEventSystraceRecorder();
+ virtual ~TimelineEventSystraceRecorder();
const char* name() const { return "Systrace"; }
@@ -742,7 +741,7 @@ class TimelineEventStartupRecorder : public TimelineEventFixedBufferRecorder {
public:
explicit TimelineEventStartupRecorder(intptr_t capacity = kDefaultCapacity)
: TimelineEventFixedBufferRecorder(capacity) {}
- ~TimelineEventStartupRecorder() {}
+ virtual ~TimelineEventStartupRecorder() {}
const char* name() const { return "Startup"; }
@@ -756,7 +755,7 @@ class TimelineEventStartupRecorder : public TimelineEventFixedBufferRecorder {
class TimelineEventCallbackRecorder : public TimelineEventRecorder {
public:
TimelineEventCallbackRecorder();
- ~TimelineEventCallbackRecorder();
+ virtual ~TimelineEventCallbackRecorder();
void PrintJSON(JSONStream* js, TimelineEventFilter* filter);
void PrintTraceEvent(JSONStream* js, TimelineEventFilter* filter);
@@ -782,6 +781,7 @@ class TimelineEventCallbackRecorder : public TimelineEventRecorder {
class TimelineEventEndlessRecorder : public TimelineEventRecorder {
public:
TimelineEventEndlessRecorder();
+ virtual ~TimelineEventEndlessRecorder();
void PrintJSON(JSONStream* js, TimelineEventFilter* filter);
void PrintTraceEvent(JSONStream* js, TimelineEventFilter* filter);
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698