Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2621153006: Copy scanner and parser to own packages. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Copy scanner and parser to own packages. Copied from b08fb1373f88121bb4056adce9b71849a5bede2a: pkg/{compiler/lib/src/parser/partial_parser.dart => dart_parser/lib/src/class_member_parser.dart} pkg/{compiler/lib/src/parser => dart_parser/lib/src}/listener.dart pkg/{compiler/lib/src/parser => dart_parser/lib/src}/parser.dart pkg/{compiler/lib/src/parser/partial_parser.dart => dart_parser/lib/src/top_level_parser.dart} pkg/{compiler/lib/src/source_file_provider.dart => dart_scanner/lib/io.dart} pkg/{compiler/lib/src/scanner/scanner.dart => dart_scanner/lib/src/abstract_scanner.dart} pkg/{compiler/lib/src/scanner => dart_scanner/lib/src}/array_based_scanner.dart pkg/{compiler/lib/src/util => dart_scanner/lib/src}/characters.dart pkg/{compiler/lib/src/tokens => dart_scanner/lib/src}/keyword.dart pkg/{compiler/lib/src/tokens/precedence_constants.dart => dart_scanner/lib/src/precedence.dart} pkg/{compiler/lib/src/tokens => dart_scanner/lib/src}/token.dart pkg/{compiler/lib/src/tokens => dart_scanner/lib/src}/token_constants.dart pkg/{compiler/lib/src/scanner => dart_scanner/lib/src}/utf8_bytes_scanner.dart R=johnniwinther@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/2b4e7b5ea1946ec66b8d5ff662733c62fa00f364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7105 lines, -0 lines) Patch
A pkg/dart_parser/lib/src/class_member_parser.dart View 1 chunk +177 lines, -0 lines 0 comments Download
A pkg/dart_parser/lib/src/listener.dart View 1 chunk +637 lines, -0 lines 0 comments Download
A pkg/dart_parser/lib/src/parser.dart View 1 chunk +3014 lines, -0 lines 0 comments Download
A pkg/dart_parser/lib/src/top_level_parser.dart View 1 chunk +177 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/io.dart View 1 chunk +408 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/src/abstract_scanner.dart View 1 chunk +1187 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/src/array_based_scanner.dart View 1 chunk +233 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/src/characters.dart View 1 chunk +143 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/src/keyword.dart View 1 chunk +214 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/src/precedence.dart View 1 chunk +189 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/src/token.dart View 1 chunk +430 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/src/token_constants.dart View 1 chunk +82 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/src/utf8_bytes_scanner.dart View 1 chunk +214 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
ahe
These files are verbatim copies. git cl upload can't show that because it doesn't support ...
3 years, 11 months ago (2017-01-12 10:17:08 UTC) #3
ahe
Karl is out sick today, Johnni, could you take a look?
3 years, 11 months ago (2017-01-12 10:22:20 UTC) #5
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-12 13:03:25 UTC) #6
Siggi Cherem (dart-lang)
lgtm Now that we have a better idea of the code layout we want, maybe ...
3 years, 11 months ago (2017-01-12 20:42:21 UTC) #7
ahe
On 2017/01/12 20:42:21, Siggi Cherem (dart-lang) wrote: > lgtm > > Now that we have ...
3 years, 11 months ago (2017-01-13 02:44:33 UTC) #8
ahe
3 years, 11 months ago (2017-01-13 07:02:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b4e7b5ea1946ec66b8d5ff662733c62fa00f364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698