Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2621093002: Fuchsia: Implement recursive delete (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Implement recursive delete Currently, readdir() doesn't fill out d_type correctly, so we just do an extra stat() to get the file type. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a1579c6a45d139a4db6c3f55828a7ec5508d9d37

Patch Set 1 #

Patch Set 2 : Add asserts to test #

Patch Set 3 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -87 lines) Patch
M runtime/bin/directory_fuchsia.cc View 1 2 4 chunks +147 lines, -87 lines 0 comments Download
M runtime/tests/vm/dart/hello_fuchsia_test.dart View 1 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 11 months ago (2017-01-10 17:42:22 UTC) #2
rmacnak
lgtm
3 years, 11 months ago (2017-01-10 22:47:05 UTC) #3
zra
3 years, 11 months ago (2017-01-10 23:08:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a1579c6a45d139a4db6c3f55828a7ec5508d9d37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698