Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: ios/chrome/browser/tabs/BUILD.gn

Issue 2621083003: Implement 1:N mapping from ios::ChromeBrowserState to TabModel. (Closed)
Patch Set: Use NSMutableSet<TabModel*>* to hold the TabModels. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab_model.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/BUILD.gn
diff --git a/ios/chrome/browser/tabs/BUILD.gn b/ios/chrome/browser/tabs/BUILD.gn
index 15f57eb63860bf38425293856d2acbf200d3dc7f..4a2edda58a0f00b5417758a05bf42778e99bcc9d 100644
--- a/ios/chrome/browser/tabs/BUILD.gn
+++ b/ios/chrome/browser/tabs/BUILD.gn
@@ -8,6 +8,7 @@ source_set("tabs") {
"tab_delegate.h",
"tab_dialog_delegate.h",
"tab_model.h",
+ "tab_model_list.h",
"tab_model_observer.h",
"tab_model_order_controller.h",
"tab_model_synced_window_delegate.h",
@@ -36,6 +37,7 @@ source_set("tabs_internal") {
]
deps = [
":tabs",
+ ":tabs_internal_arc",
"//base",
"//components/content_settings/core/browser",
"//components/favicon/core",
@@ -106,12 +108,26 @@ source_set("tabs_internal") {
"//ui/base",
"//url",
]
+ allow_circular_includes_from = [ ":tabs_internal_arc" ]
libs = [
"CoreLocation.framework",
"UIKit.framework",
]
}
+source_set("tabs_internal_arc") {
+ sources = [
+ "tab_model_list.mm",
+ ]
+ deps = [
+ ":tabs",
+ "//base",
+ "//ios/chrome/browser/browser_state",
+ ]
+ libs = [ "Foundation.framework" ]
+ configs += [ "//build/config/compiler:enable_arc" ]
+}
+
source_set("unit_tests") {
testonly = true
sources = [
@@ -122,6 +138,7 @@ source_set("unit_tests") {
deps = [
":tabs",
":tabs_internal",
+ ":unit_tests_arc",
"//base",
"//components/bookmarks/test",
"//components/history/core/browser",
@@ -147,3 +164,20 @@ source_set("unit_tests") {
"//third_party/ocmock",
]
}
+
+source_set("unit_tests_arc") {
+ testonly = true
+ sources = [
+ "tab_model_list_unittest.mm",
+ ]
+ deps = [
+ ":tabs",
+ ":tabs_internal",
+ "//base",
+ "//ios/chrome/browser/browser_state:test_support",
+ "//ios/chrome/browser/sessions:test_support",
+ "//ios/web:test_support",
+ "//testing/gtest",
+ ]
+ configs += [ "//build/config/compiler:enable_arc" ]
+}
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab_model.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698