Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: ios/chrome/browser/tabs/tab_model_unittest.mm

Issue 2621083003: Implement 1:N mapping from ios::ChromeBrowserState to TabModel. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab_model_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_model_unittest.mm b/ios/chrome/browser/tabs/tab_model_unittest.mm
index d99a886419c6e5a8cdf66fcf18b1c232b2c8b296..4d2e906842ff27a399bc0dd96a3403e288a91727 100644
--- a/ios/chrome/browser/tabs/tab_model_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_model_unittest.mm
@@ -147,7 +147,7 @@ class TabModelTest : public PlatformTest {
TestChromeBrowserState::Builder test_cbs_builder;
chrome_browser_state_ = test_cbs_builder.Build();
- sessionWindow_.reset([[SessionWindowIOS new] retain]);
+ sessionWindow_.reset([[SessionWindowIOS alloc] init]);
sdefresne 2017/01/10 17:49:28 nit: this is unrelated but I based my tab_model_li
marq (ping after 24h) 2017/01/11 15:56:47 Acknowledged.
// Create tab model with just a dummy session service so the async state
// saving doesn't trigger unless actually wanted.
base::scoped_nsobject<TestSessionService> test_service(

Powered by Google App Engine
This is Rietveld 408576698