Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Issue 2621033003: [Payments] Currency formatter for order amounts. (Closed)
Patch Set: Initial Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
index d085b26e922c1f849152ad1e20dd51d91c05c81e..5cf3b017eaa669f9d9bb6f88bdc8af5681561f8f 100644
--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
@@ -9,11 +9,14 @@
#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/ui/views/payments/payment_request_dialog.h"
#include "chrome/browser/ui/views/payments/payment_request_views_util.h"
#include "chrome/grit/generated_resources.h"
+#include "components/payments/currency_formatter.h"
#include "components/payments/payment_request.h"
#include "components/strings/grit/components_strings.h"
+#include "third_party/icu/source/common/unicode/locid.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/color_utils.h"
@@ -157,11 +160,15 @@ void PaymentSheetViewController::ButtonPressed(
std::unique_ptr<views::View>
PaymentSheetViewController::CreateOrderSummarySectionContent() {
+ const std::string formatted_amount = FormatAmountForCurrency(
+ request()->details()->total->amount->value,
+ request()->details()->total->amount->currency,
+ icu::Locale(g_browser_process->GetApplicationLocale().c_str()));
base::string16 label_value = l10n_util::GetStringFUTF16(
IDS_PAYMENT_REQUEST_ORDER_SUMMARY_SECTION_TOTAL_FORMAT,
- base::ASCIIToUTF16(request()->details()->total->label),
- base::ASCIIToUTF16(request()->details()->total->amount->currency),
- base::ASCIIToUTF16(request()->details()->total->amount->value));
+ base::UTF8ToUTF16(request()->details()->total->label),
+ base::UTF8ToUTF16(request()->details()->total->amount->currency),
+ base::UTF8ToUTF16(formatted_amount));
return base::MakeUnique<views::Label>(label_value);
}

Powered by Google App Engine
This is Rietveld 408576698