[Payments] Currency formatter for order amounts.

chrome/browser/ui/views/payments/order_summary_view_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/order_summary_view_controller.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/ui/views/payments/payment_request_dialog.h"
 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
 #include "chrome/grit/generated_resources.h"
+#include "components/payments/currency_formatter.h"
 #include "components/payments/payment_request.h"
 #include "components/strings/grit/components_strings.h"
+#include "third_party/icu/source/common/unicode/locid.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/view.h"
 
 namespace payments {
 
 OrderSummaryViewController::OrderSummaryViewController(
     PaymentRequest* request,
     PaymentRequestDialog* dialog)
     : PaymentRequestSheetController(request, dialog) {}
 
 OrderSummaryViewController::~OrderSummaryViewController() {}
 
 std::unique_ptr<views::View> OrderSummaryViewController::CreateView() {
   std::unique_ptr<views::View> content_view = base::MakeUnique<views::View>();
 
   views::GridLayout* layout = new views::GridLayout(content_view.get());
   content_view->SetLayoutManager(layout);
   views::ColumnSet* columns = layout->AddColumnSet(0);
   columns->AddColumn(views::GridLayout::FILL, views::GridLayout::CENTER,
                      0, views::GridLayout::USE_PREF, 0, 0);
 
+  const std::string formatted_amount = FormatAmountForCurrency(

[please use gerrit instead, 2017/01/11 18:29:30]

nit1: no need for const, because a quick perusal of this function shows that the
formatted amount is never changed.

nit2: If you return base::stirng16 from FormatAmountForCurrency(), then it's
more clear that the output is intended to be displayed to the user.

nit3: ICU operations can be expensive. It's best to calculate this value once in
the model and share it among the views.

nit4: If |total->amount->currencySystem| is present and is not set to
"urn:iso:std:iso:4217", then the formatter should be aware that
|total->amount->currency| is not ISO code that can be interpreted by ICU. For
example, the formatter should use "" instead of "$" for "USD", if the
currencySystem is not ISO. 

https://w3c.github.io/browser-payment-api/#paymentcurrencyamount-dictionary

[Mathieu, 2017/01/11 22:22:25]

Done.

+      request()->details()->total->amount->value,
+      request()->details()->total->amount->currency,
+      icu::Locale(g_browser_process->GetApplicationLocale().c_str()));
   layout->StartRow(0, 0);
   layout->AddView(new views::Label(l10n_util::GetStringFUTF16(
       IDS_PAYMENT_REQUEST_ORDER_SUMMARY_SECTION_TOTAL_FORMAT,
-      base::ASCIIToUTF16(request()->details()->total->label),
-      base::ASCIIToUTF16(request()->details()->total->amount->value),
-      base::ASCIIToUTF16(request()->details()->total->amount->currency))));
+      base::UTF8ToUTF16(request()->details()->total->label),
+      base::UTF8ToUTF16(request()->details()->total->amount->currency),
+      base::UTF8ToUTF16(formatted_amount))));
 
   return payments::CreatePaymentView(
       CreateSheetHeaderView(
           true,
           l10n_util::GetStringUTF16(IDS_PAYMENT_REQUEST_ORDER_SUMMARY_TITLE),
           this),
       std::move(content_view));
 }
 
 void OrderSummaryViewController::ButtonPressed(
     views::Button* sender, const ui::Event& event) {
   switch (sender->tag()) {
     case static_cast<int>(PaymentRequestCommonTags::CLOSE_BUTTON_TAG):
       dialog()->CloseDialog();
       break;
     case static_cast<int>(PaymentRequestCommonTags::BACK_BUTTON_TAG):
       dialog()->GoBack();
       break;
     default:
       NOTREACHED();
   }
 }
 
 }  // namespace payments