Test that OmniboxViewViews has opaque background.

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/command_line.h"
@@ skipping 1393 matching lines @@
 
 void LocationBarView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   InstantServiceFactory::GetForProfile(profile())->OnOmniboxStartMarginChanged(
       bounds().x());
 
   OmniboxPopupView* popup = omnibox_view_->model()->popup_model()->view();
   if (popup->IsOpen())
     popup->UpdatePopupAppearance();
 }
 
 void LocationBarView::OnFocus() {

[Peter Kasting, 2014/05/06 21:28:33]

Is it possible to remove this function entirely and just make the omnibox view
automatically get focus by virtue of being the only focusable child?

[Daniel Erat, 2014/05/07 18:43:02]

seems to work for chrome os and linux. dominic, would you mind testing this on
windows again?

-  // Focus the view widget first which implements accessibility for
-  // Chrome OS.  It is noop on Win. This should be removed once
-  // Chrome OS migrates to aura, which uses Views' textfield that receives
-  // focus. See crbug.com/106428.
-  NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, false);
-
-  // Then focus the native location view which implements accessibility for
-  // Windows.
   omnibox_view_->SetFocus();
 }
 
 void LocationBarView::OnPaint(gfx::Canvas* canvas) {
   View::OnPaint(canvas);
 
   // Fill the location bar background color behind the border.  Parts of the
   // border images are meant to rest atop the toolbar background and parts atop
   // the omnibox background, so we can't just blindly fill our entire bounds.
   gfx::Rect bounds(GetContentsBounds());
   bounds.Inset(GetHorizontalEdgeThickness(), vertical_edge_thickness());
   SkColor color(GetColor(ToolbarModel::NONE, BACKGROUND));
   if (is_popup_mode_) {
     canvas->FillRect(bounds, color);
   } else {
     SkPaint paint;
     paint.setStyle(SkPaint::kFill_Style);
     paint.setColor(color);
     const int kBorderCornerRadius = 2;
     canvas->DrawRoundRect(bounds, kBorderCornerRadius, paint);
   }
 
   // The border itself will be drawn in PaintChildren() since it includes an
   // inner shadow which should be drawn over the contents.
 }
 
 void LocationBarView::PaintChildren(gfx::Canvas* canvas) {
   // Paint all the children except for the origin chip and the search button,
   // which will be painted after the border.
-  for (int i = 0, count = child_count(); i < count; ++i)
+  for (int i = 0, count = child_count(); i < count; ++i) {
     if (!child_at(i)->layer() &&
         (child_at(i) != origin_chip_view_) &&
         (child_at(i) != search_button_))
       child_at(i)->Paint(canvas);
+  }
 
   // For non-InstantExtendedAPI cases, if necessary, show focus rect. As we need
   // the focus rect to appear on top of children we paint here rather than
   // OnPaint().
   // Note: |Canvas::DrawFocusRect| paints a dashed rect with gray color.
   if (show_focus_rect_ && HasFocus())
     canvas->DrawFocusRect(omnibox_view_->bounds());
 
   // Maximized popup windows don't draw the horizontal edges.  We implement this
   // by simply expanding the paint area outside the view by the edge thickness.
@@ skipping 186 matching lines @@
 void LocationBarView::ModelChanged(const SearchModel::State& old_state,
                                    const SearchModel::State& new_state) {
   const bool visible = !GetToolbarModel()->input_in_progress() &&
       new_state.voice_search_supported;
   if (mic_search_view_->visible() != visible) {
     mic_search_view_->SetVisible(visible);
     Layout();
   }
 }