Issue 262093011: Revert of Make sure that ScratchBuffer::Allocate() always return 8-byte aligned address.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262093011: Revert of Make sure that ScratchBuffer::Allocate() always return 8-byte aligned address. (Closed)

Created:
6 years, 7 months ago by Mike West

Modified:
6 years, 7 months ago

Reviewers:
darin (slow to review), yzshen1

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Make sure that ScratchBuffer::Allocate() always return 8-byte aligned address. (https://codereview.chromium.org/265403003/) Reason for revert: This broke mojo unit tests under linux dbg: see http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/12593/steps/mojo_public_bindings_unittests/logs/Alignment for detail. Original issue's description: > Make sure that ScratchBuffer::Allocate() always return 8-byte aligned addresses. > > BUG=None > TEST=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268405 TBR=darin@chromium.org,yzshen@chromium.org NOTREECHECKS=true NOTRY=true BUG=None

Patch Set 1 #

Created: 6 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -21 lines)			Patch
	M	mojo/public/cpp/bindings/lib/scratch_buffer.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
	M	mojo/public/cpp/bindings/tests/buffer_unittest.cc	View		1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike West

Created Revert of Make sure that ScratchBuffer::Allocate() always return 8-byte aligned address.

6 years, 7 months ago (2014-05-06 07:03:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/262093011/1

6 years, 7 months ago (2014-05-06 07:04:21 UTC) #2

Nevermind, already reverted. Sorry for the noise.

Expand Messages | Collapse Messages