Chromium Code Reviews Chromium Code Reviews
Issue 262093007:
Tighten error checking from SVGLength parsing (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html |
| diff --git a/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html b/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..af439cd8a5a1fed8ed6004f8d0721866f1c48b9f |
| --- /dev/null |
| +++ b/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html |
| @@ -0,0 +1,39 @@ |
| +<!doctype html> |
| +<!-- Simple test for |
| + |
| + https://svgwg.org/svg2-draft/styling.html#WidthProperty |
| + https://svgwg.org/svg2-draft/styling.html#HeightProperty |
| + |
| + "For backwards compatibility, when the ‘width’ or ‘height’ |
| + properties are specified as a presentation attributes, only the |
| + values that match the <length> production shall be mapped to |
| + CSS. Any other value must be treated as invalid." --> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<span style="width:200px"> |
| + <svg id="svg"></svg> |
| + <svg width="400"> |
| + <foreignobject id="fO"> |
| + </foreignobject> |
| + </svg> |
| +</span> |
| +<script> |
| + function setWidth(selector, width) { |
| + try { document.querySelector(selector).setAttribute('width', width); } catch (err) {} |
| + } |
| + function getWidth(selector) { |
| + return document.querySelector(selector).getBoundingClientRect().width; |
| + } |
| + var invalid_widths = [ 'auto', 'initial', 'inherit', 'foo' ]; |
| + invalid_widths.forEach(function(invalid_width) { |
| + setWidth('#svg', invalid_width); |
| + test(function() { |
| + assert_equals(getWidth('#svg'), 0); |
| + }, "Test width '" + invalid_width + "' on SVGSVGElement"); |
| + |
| + setWidth('#fo', invalid_width); |
|
pdr.
2014/05/05 16:53:11
This won't match #fO above.
davve
2014/05/06 07:05:19
Good eyes!
(I wish I could use querySelector('for
|
| + test(function() { |
| + assert_equals(getWidth('#fO'), 0); |
| + }, "Test width '" + invalid_width + "' on SVGForeignObject"); |
| + }); |
| +</script> |
