Source/core/dom/shadow/ElementShadow.cpp - Issue 262093006: Oilpan: Make the Node hierarchy RefCountedGarbageCollected instead of TreeShared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ElementShadow.cpp

Issue 262093006: Oilpan: Make the Node hierarchy RefCountedGarbageCollected instead of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address more comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/shadow/ElementShadow.cpp

diff --git a/Source/core/dom/shadow/ElementShadow.cpp b/Source/core/dom/shadow/ElementShadow.cpp

index ba11a7035476768c2f723cc0defafba3f50454b5..f0dde8e798cf63564359013f2ea4dfd5c607e46b 100644

--- a/Source/core/dom/shadow/ElementShadow.cpp

+++ b/Source/core/dom/shadow/ElementShadow.cpp

@@ -135,7 +135,9 @@ ElementShadow::ElementShadow()

ElementShadow::~ElementShadow()

{

+#if !ENABLE(OILPAN)

removeDetachedShadowRoots();

+#endif

}

ShadowRoot& ElementShadow::addShadowRoot(Element& shadowHost, ShadowRoot::ShadowRootType type)

@@ -350,4 +352,9 @@ void ElementShadow::clearDistribution()

root->setShadowInsertionPointOfYoungerShadowRoot(nullptr);

}

+void ElementShadow::trace(Visitor* visitor)

+ visitor->trace(m_shadowRoots.head());

haraken 2014/05/06 04:20:16 Let's add a comment to mention why we just need to

Mads Ager (chromium) 2014/05/06 08:26:00 Done.

} // namespace

« Source/core/dom/UserActionElementSet.h ('K') | « Source/core/dom/shadow/ElementShadow.h ('k') | Source/core/dom/shadow/ShadowRoot.h » ('j') | Source/core/dom/shadow/ShadowRoot.cpp » ('J')