Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: Source/core/dom/ContainerNode.h

Issue 262093006: Oilpan: Make the Node hierarchy RefCountedGarbageCollected instead of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Another build fix. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/ContainerNode.h
diff --git a/Source/core/dom/ContainerNode.h b/Source/core/dom/ContainerNode.h
index e372bff068a43daaf556eefcd8cc3a66d1c8fc62..99543d230c3308ecd517eb6de1b2df2dfaff6469 100644
--- a/Source/core/dom/ContainerNode.h
+++ b/Source/core/dom/ContainerNode.h
@@ -190,6 +190,8 @@ public:
void disconnectDescendantFrames();
+ virtual void trace(Visitor*) OVERRIDE;
+
protected:
ContainerNode(TreeScope*, ConstructionType = CreateContainer);
@@ -199,7 +201,10 @@ protected:
template<class GenericNode, class GenericNodeContainer>
friend void Private::addChildNodesToDeletionQueue(GenericNode*& head, GenericNode*& tail, GenericNodeContainer&);
+#if !ENABLE(OILPAN)
void removeDetachedChildren();
+#endif
+
void setFirstChild(Node* child) { m_firstChild = child; }
void setLastChild(Node* child) { m_lastChild = child; }
@@ -227,8 +232,8 @@ private:
bool getUpperLeftCorner(FloatPoint&) const;
bool getLowerRightCorner(FloatPoint&) const;
- Node* m_firstChild;
- Node* m_lastChild;
+ RawPtrWillBeMember<Node> m_firstChild;
+ RawPtrWillBeMember<Node> m_lastChild;
};
#ifndef NDEBUG
@@ -249,8 +254,8 @@ inline bool ContainerNode::hasChildCount(unsigned count) const
inline ContainerNode::ContainerNode(TreeScope* treeScope, ConstructionType type)
: Node(treeScope, type)
- , m_firstChild(0)
- , m_lastChild(0)
+ , m_firstChild(nullptr)
+ , m_lastChild(nullptr)
{
}

Powered by Google App Engine
This is Rietveld 408576698