Oilpan: Make the Node hierarchy RefCountedGarbageCollected instead of TreeShared.

Source/core/html/forms/ValidationMessage.cpp

 /*
  * Copyright (C) 2010, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 namespace WebCore {
 
 ALWAYS_INLINE ValidationMessage::ValidationMessage(HTMLFormControlElement* element)
     : m_element(element)
 {
     ASSERT(m_element);
 }
 
 ValidationMessage::~ValidationMessage()
 {
+#if !ENABLE(OILPAN)
     if (ValidationMessageClient* client = validationMessageClient())
         client->hideValidationMessage(*m_element);

[haraken, 2014/05/06 04:20:16]

Now you're calling hideValidationMessage() in
HTMLFormControllerElement::removedFrom(). So, for consistency, I'd remove
hideValidationMessage() from here and instead add:

~HTMLFormControllerElement() {
#if !ENABLE(OILPAN)
  hideValidationMessage();
#endif
}

[Mads Ager (chromium), 2014/05/06 08:26:00]

Yeah, let me do that. There is a comment in the ValidationMessage.h file that
ValidationMessage should be removed in any case. Doing this will move a bit in
that direction.

+#endif
 }
 
 PassOwnPtr<ValidationMessage> ValidationMessage::create(HTMLFormControlElement* element)
 {
     return adoptPtr(new ValidationMessage(element));
 }
 
 ValidationMessageClient* ValidationMessage::validationMessageClient() const
 {
     Page* page = m_element->document().page();
@@ skipping 21 matching lines @@
 }
 
 bool ValidationMessage::isVisible() const
 {
     if (ValidationMessageClient* client = validationMessageClient())
         return client->isValidationMessageVisible(*m_element);
     return false;
 }
 
 } // namespace WebCore