Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: Source/core/svg/properties/SVGAnimatedProperty.cpp

Issue 262093006: Oilpan: Make the Node hierarchy RefCountedGarbageCollected instead of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Another build fix. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 { 44 {
45 ASSERT(m_contextElement); 45 ASSERT(m_contextElement);
46 ASSERT(m_attributeName != nullQName()); 46 ASSERT(m_attributeName != nullQName());
47 // FIXME: setContextElement should be delayed until V8 wrapper is created. 47 // FIXME: setContextElement should be delayed until V8 wrapper is created.
48 // FIXME: oilpan: or we can remove this backref ptr hack in oilpan. 48 // FIXME: oilpan: or we can remove this backref ptr hack in oilpan.
49 m_contextElement->setContextElement(); 49 m_contextElement->setContextElement();
50 } 50 }
51 51
52 SVGAnimatedPropertyBase::~SVGAnimatedPropertyBase() 52 SVGAnimatedPropertyBase::~SVGAnimatedPropertyBase()
53 { 53 {
54 #if !ENABLE(OILPAN)
54 ASSERT(!isAnimating()); 55 ASSERT(!isAnimating());
kouhei (in TOK) 2014/05/07 04:11:51 isAnimating() check only touches SVGAnimatedProper
Mads Ager (chromium) 2014/05/07 12:13:16 OK, thanks Kouhei. I'll add a FIXME here and file
56 #endif
55 } 57 }
56 58
57 void SVGAnimatedPropertyBase::animationStarted() 59 void SVGAnimatedPropertyBase::animationStarted()
58 { 60 {
59 ASSERT(!isAnimating()); 61 ASSERT(!isAnimating());
60 m_isAnimating = true; 62 m_isAnimating = true;
61 } 63 }
62 64
63 void SVGAnimatedPropertyBase::animationEnded() 65 void SVGAnimatedPropertyBase::animationEnded()
64 { 66 {
65 synchronizeAttribute(); 67 synchronizeAttribute();
66 ASSERT(isAnimating()); 68 ASSERT(isAnimating());
67 m_isAnimating = false; 69 m_isAnimating = false;
68 } 70 }
69 71
70 void SVGAnimatedPropertyBase::synchronizeAttribute() 72 void SVGAnimatedPropertyBase::synchronizeAttribute()
71 { 73 {
72 ASSERT(needsSynchronizeAttribute()); 74 ASSERT(needsSynchronizeAttribute());
73 AtomicString value(currentValueBase()->valueAsString()); 75 AtomicString value(currentValueBase()->valueAsString());
74 m_contextElement->setSynchronizedLazyAttribute(m_attributeName, value); 76 m_contextElement->setSynchronizedLazyAttribute(m_attributeName, value);
75 } 77 }
76 78
77 bool SVGAnimatedPropertyBase::isSpecified() const 79 bool SVGAnimatedPropertyBase::isSpecified() const
78 { 80 {
79 return isAnimating() || contextElement()->hasAttribute(attributeName()); 81 return isAnimating() || contextElement()->hasAttribute(attributeName());
80 } 82 }
81 83
82 } // namespace WebCore 84 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698