Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: ash/mus/root_window_controller.h

Issue 2620913003: Removes WmRootWindowController subclasses (Closed)
Patch Set: WmLookupAura::GetRootWindowControllerWithDisplayId needs to handle null Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/root_window_controller.h
diff --git a/ash/mus/root_window_controller.h b/ash/mus/root_window_controller.h
index d4c5532d2ae74b9574ea95336260a65f71305a8f..84d2f23584750be231a41da3beed31df80153941 100644
--- a/ash/mus/root_window_controller.h
+++ b/ash/mus/root_window_controller.h
@@ -8,14 +8,12 @@
#include <memory>
#include "ash/mus/disconnected_app_handler.h"
+#include "ash/root_window_controller.h"
#include "services/ui/public/interfaces/window_manager_constants.mojom.h"
#include "ui/display/display.h"
namespace aura {
class WindowTreeHostMus;
-namespace client {
-class WindowParentingClient;
-}
}
namespace gfx {
@@ -27,13 +25,9 @@ class Connector;
}
namespace ash {
-
-class WmShelf;
-
namespace mus {
class WindowManager;
-class WmRootWindowControllerMus;
class WmTestBase;
class WmTestHelper;
class WmWindowMus;
@@ -46,18 +40,19 @@ class RootWindowController {
RootWindowController(
WindowManager* window_manager,
std::unique_ptr<aura::WindowTreeHostMus> window_tree_host,
- const display::Display& display);
+ const display::Display& display,
+ ash::RootWindowController::RootWindowType root_window_type);
~RootWindowController();
+ // Returns the RootWindowController for |window|'s root.
+ static RootWindowController* ForWindow(aura::Window* window);
+
void Shutdown();
service_manager::Connector* GetConnector();
aura::Window* root();
const aura::Window* root() const;
- WmRootWindowControllerMus* wm_root_window_controller() {
- return wm_root_window_controller_.get();
- }
aura::Window* NewTopLevelWindow(
ui::mojom::WindowType window_type,
@@ -70,13 +65,13 @@ class RootWindowController {
WindowManager* window_manager() { return window_manager_; }
- aura::WindowTreeHostMus* window_tree_host() {
- return window_tree_host_.get();
- }
+ aura::WindowTreeHostMus* window_tree_host() { return window_tree_host_; }
const display::Display& display() const { return display_; }
- WmShelf* wm_shelf() { return wm_shelf_.get(); }
+ ash::RootWindowController* ash_root_window_controller() {
+ return ash_root_window_controller_.get();
+ }
private:
friend class WmTestBase;
@@ -88,16 +83,13 @@ class RootWindowController {
gfx::Rect GetMaximizedWindowBounds() const;
WindowManager* window_manager_;
- std::unique_ptr<aura::WindowTreeHostMus> window_tree_host_;
+ std::unique_ptr<ash::RootWindowController> ash_root_window_controller_;
+ // Owned by |ash_root_window_controller_|.
+ aura::WindowTreeHostMus* window_tree_host_;
int window_count_ = 0;
display::Display display_;
- std::unique_ptr<WmRootWindowControllerMus> wm_root_window_controller_;
- std::unique_ptr<WmShelf> wm_shelf_;
-
- std::unique_ptr<aura::client::WindowParentingClient> parenting_client_;
-
std::unique_ptr<DisconnectedAppHandler> disconnected_app_handler_;
DISALLOW_COPY_AND_ASSIGN(RootWindowController);

Powered by Google App Engine
This is Rietveld 408576698