Removes WmRootWindowController subclasses

ash/shell.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELL_H_
 #define ASH_SHELL_H_
 
 #include <memory>
 #include <utility>
 #include <vector>
 
 #include "ash/ash_export.h"
 #include "ash/metrics/user_metrics_recorder.h"
 #include "ash/public/cpp/shelf_types.h"
 #include "ash/wm/cursor_manager_chromeos.h"
 #include "ash/wm/system_modal_container_event_filter_delegate.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "ui/aura/window.h"
 #include "ui/display/screen.h"
 #include "ui/events/event_target.h"
 #include "ui/wm/core/cursor_manager.h"
 
 namespace aura {
 class RootWindow;
 class Window;
+class WindowTreeClient;
 namespace client {
 class ActivationClient;
 class FocusClient;
 }
 }
 
 namespace chromeos {
 class AudioA11yController;
 }
 
@@ skipping 138 matching lines @@
   static int64_t GetTargetDisplayId();
 
   // Returns all root windows.
   static aura::Window::Windows GetAllRootWindows();
 
   static aura::Window* GetContainer(aura::Window* root_window,
                                     int container_id);
   static const aura::Window* GetContainer(const aura::Window* root_window,
                                           int container_id);
 
+  // TODO(sky): better isolate this.

[James Cook, 2017/01/10 22:41:14]

Hrm. Yeah, this is kind of ugly. Could it live somewhere else? Maybe in
WmRootWindowController or RootWindowController? At least those are a bit less
visible than Shell.

[sky, 2017/01/10 23:06:57]

I put it in Shell as it isn't related to a single root (RootWindowController is
for a single root) and I suspect other places are going to need it.

+  static void set_window_tree_client(aura::WindowTreeClient* client) {
+    window_tree_client_ = client;
+  }
+
+  static aura::WindowTreeClient* window_tree_client() {
+    return window_tree_client_;
+  }
+
   // Creates a default views::NonClientFrameView for use by windows in the
   // Ash environment.
   views::NonClientFrameView* CreateDefaultNonClientFrameView(
       views::Widget* widget);
 
   // Sets work area insets of the display containing |window|, pings observers.
   void SetDisplayWorkAreaInsets(aura::Window* window,
                                 const gfx::Insets& insets);
 
   // Called when the user logs in.
@@ skipping 210 matching lines @@
   bool CanWindowReceiveEvents(aura::Window* window) override;
 
   // Overridden from ui::EventTarget:
   bool CanAcceptEvent(const ui::Event& event) override;
   EventTarget* GetParentTarget() override;
   std::unique_ptr<ui::EventTargetIterator> GetChildIterator() const override;
   ui::EventTargeter* GetEventTargeter() override;
 
   static Shell* instance_;
 
+  static aura::WindowTreeClient* window_tree_client_;

[James Cook, 2017/01/10 22:41:14]

Is this only set when running with mus? If so, please document that.

[sky, 2017/01/10 23:06:57]

Done.

+
   // If set before the Shell is initialized, the mouse cursor will be hidden
   // when the screen is initially created.
   static bool initially_hide_cursor_;
 
   std::unique_ptr<ScopedOverviewAnimationSettingsFactoryAura>
       scoped_overview_animation_settings_factory_;
   std::unique_ptr<WmShellAura> wm_shell_;
 
   // The CompoundEventFilter owned by aura::Env object.
   std::unique_ptr<::wm::CompoundEventFilter> env_filter_;
@@ skipping 101 matching lines @@
   std::unique_ptr<GPUSupport> gpu_support_;
 
   std::unique_ptr<ImmersiveHandlerFactoryAsh> immersive_handler_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Shell);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SHELL_H_