Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 2620913002: Remove crash keys for 630495 and 630496 (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/cast_crash_keys.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index 78293ca8720f53ccc0138ad180a1c7b60ad5d5f8..c0e32cee57284480dc9383c33efd166ab64c10c8 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -333,13 +333,6 @@ void ServiceWorkerDispatcherHost::OnRegisterServiceWorker(
std::vector<GURL> urls = {provider_host->document_url(), pattern, script_url};
if (!ServiceWorkerUtils::AllOriginsMatchAndCanAccessServiceWorkers(urls)) {
- // Temporary debugging for https://crbug.com/630495
- base::debug::ScopedCrashKey host_url_key(
- "swdh_register_cannot_host_url", provider_host->document_url().spec());
- base::debug::ScopedCrashKey scope_url_key("swdh_register_cannot_scope_url",
- pattern.spec());
- base::debug::ScopedCrashKey script_url_key(
- "swdh_register_cannot_script_url", script_url.spec());
bad_message::ReceivedBadMessage(this, bad_message::SWDH_REGISTER_CANNOT);
return;
}
@@ -558,12 +551,6 @@ void ServiceWorkerDispatcherHost::OnGetRegistration(
std::vector<GURL> urls = {provider_host->document_url(), document_url};
if (!ServiceWorkerUtils::AllOriginsMatchAndCanAccessServiceWorkers(urls)) {
- // Temporary debugging for https://crbug.com/630496
- base::debug::ScopedCrashKey host_url_key(
- "swdh_get_registration_cannot_host_url",
- provider_host->document_url().spec());
- base::debug::ScopedCrashKey document_url_key(
- "swdh_get_registration_cannot_document_url", document_url.spec());
bad_message::ReceivedBadMessage(this,
bad_message::SWDH_GET_REGISTRATION_CANNOT);
return;
« no previous file with comments | « chromecast/crash/cast_crash_keys.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698