third_party/WebKit/LayoutTests/fast/forms/radio/radio-input-keyboard-navigation.html - Issue 2620843004: Radio input keyboard navigation scroll

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/radio/radio-input-keyboard-navigation.html

Issue 2620843004: Radio input keyboard navigation scroll (Closed)

Patch Set: This patch scrolls the parent container while navigating through the radio input using keyboard Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/platform/linux/fast/forms/radio/radio-input-keyboard-navigation-expected.txt » ('j') | third_party/WebKit/LayoutTests/platform/linux/fast/forms/radio/radio-input-keyboard-navigation-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	tkent 2017/01/17 00:11:53 Please do not indent HTML tags. It has almost no Please do not indent HTML tags. It has almost no benefit. Write <html> <head> <script ...> <script ...> instead of <html> <head> <script ..> <script ..>
	4 <script src="../../../resources/testharness.js"></script>

	5 <script src="../../../resources/testharnessreport.js"></script>

	6 <style>

	7 #test1 {

	8 max-height: 65px;

	9 overflow: auto;

	10 width: 100px;

	11 height:65px;
	tkent 2017/01/17 00:11:53 Add a space after ':' for consistency. Add a space after ':' for consistency.
	12 }

	13 input[type="radio"]{
	tkent 2017/01/17 00:11:53 Add a space after ']' for consistency. Add a space after ']' for consistency.
	14 display: block;

	15 }

	16 </style>

	17 </head>

	18 <body>

	19 <div id="test1">

	20 <input id="radio_1" type="radio" name="foo" checked>

	21 <input id="radio_2" type="radio" name="foo">
	tkent 2017/01/17 00:11:53 id="radio_2" to id="radio_6" are unnecessary. id="radio_2" to id="radio_6" are unnecessary.
	22 <input id="radio_3" type="radio" name="foo">

	23 <input id="radio_4" type="radio" name="foo">

	24 <input id="radio_5" type="radio" name="foo">

	25 <input id="radio_6" type="radio" name="foo">

	26 </div>

	27 <script>

	28 test(function() {

	29 document.getElementById("radio_1").focus();
	tkent 2017/01/17 00:11:53 nit: You can remove id="radio_1" by document.query nit: You can remove id="radio_1" by document.querySelector("input").focus();
	30 if(window.eventSender) {
	tkent 2017/01/17 00:11:53 assert_exists(window, "eventSender"); assert_exists(window, "eventSender");
	31 for(var i = 0; i < 5; i++){
	tkent 2017/01/17 00:11:53 Add a space after "for". Add a space after ')'. Add a space after "for". Add a space after ')'.
	32 window.eventSender.keyDown("Arro wDown");

	33 }

	34 }

	35 assert_greater_than(document.getElementById("tes t1").scrollTop, 0);

	36 }, "Parent container should be scrolled while navigating through radio inputs");

	37 </script>

	38 </body>

	39 </html>

OLD	NEW