Chromium Code Reviews| Index: chrome/test/chromedriver/js/call_function.js |
| diff --git a/chrome/test/chromedriver/js/call_function.js b/chrome/test/chromedriver/js/call_function.js |
| index 6dee10578534cd64d5db4425d75241e6605d61ec..d79e70d8a8e578788dbf16ddea6363fc5d369bb1 100644 |
| --- a/chrome/test/chromedriver/js/call_function.js |
| +++ b/chrome/test/chromedriver/js/call_function.js |
| @@ -260,7 +260,8 @@ function wrap(value) { |
| // frames[0].document.body instanceof Object == false even though |
| // typeof(frames[0].document.body) == 'object'. |
| if ((typeof(value) == 'object' && value != null) || |
| - (typeof(value) == 'function' && value instanceof Element)) { |
| + (typeof(value) == 'function' && value.nodeName && |
| + value.nodeType == Node.ELEMENT_NODE)) { |
|
PhistucK
2017/01/13 09:15:40
For consistency, I think you should use the above
samuong
2017/01/13 18:26:42
Sounds reasonable, I've created https://codereview
|
| var nodeType = value['nodeType']; |
| if (nodeType == NodeType.ELEMENT || nodeType == NodeType.DOCUMENT |
| || (SHADOW_DOM_ENABLED && value instanceof ShadowRoot)) { |