[chromedriver] Use nodeType instead of instanceof.

chrome/test/chromedriver/js/call_function.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Enum for WebDriver status codes.
  * @enum {number}
  */
 var StatusCode = {
   STALE_ELEMENT_REFERENCE: 10,
@@ skipping 242 matching lines @@
  */
 function wrap(value) {
   // As of crrev.com/1316933002, typeof() for some elements will return
   // 'function', not 'object'. So we need to check for both non-null objects, as
   // well Elements that also happen to be callable functions (e.g. <embed> and
   // <object> elements). Note that we can not use |value instanceof Object| here
   // since this does not work with frames/iframes, for example
   // frames[0].document.body instanceof Object == false even though
   // typeof(frames[0].document.body) == 'object'.
   if ((typeof(value) == 'object' && value != null) ||
-      (typeof(value) == 'function' && value instanceof Element)) {
+      (typeof(value) == 'function' && value.nodeName &&
+       value.nodeType == Node.ELEMENT_NODE)) {

[PhistucK, 2017/01/13 09:15:40]

For consistency, I think you should use the above defined NodeType.ELEMENT (and
below used).
This has the benefit of not breaking in case Node is also redefined.

[samuong, 2017/01/13 18:26:42]

Sounds reasonable, I've created https://codereview.chromium.org/2629403003/ for
this. Thanks!

     var nodeType = value['nodeType'];
     if (nodeType == NodeType.ELEMENT || nodeType == NodeType.DOCUMENT
         || (SHADOW_DOM_ENABLED && value instanceof ShadowRoot)) {
       var wrapped = {};
       var root = getNodeRootThroughAnyShadows(value);
       wrapped[ELEMENT_KEY] = getPageCache(root, w3cEnabled).storeItem(value);
       return wrapped;
     }
 
     var obj = (typeof(value.length) == 'number') ? [] : {};
@@ skipping 72 matching lines @@
     var returnValue = wrap(func.apply(null, unwrap(args, cache)));
   } catch (error) {
     status = error.code || StatusCode.UNKNOWN_ERROR;
     var returnValue = error.message;
   }
   return {
       status: status,
       value: returnValue
   }
 }